6502/EightBitNet
1
0
Fork 0
mirror of https://github.com/MoleskiCoder/EightBitNet.git synced 2025-08-15 11:27:27 +00:00
Code Issues Projects Releases Wiki Activity

Speed up Z80 block operations by using values rather than reference objects, if possible.

Browse Source 
Signed-off-by: Adrian Conlon <Adrian.conlon@gmail.com>
This commit is contained in:
Adrian Conlon
2019-03-07 00:28:39 +00:00
parent 2652463106
commit 56f46a8236
1 changed files with 6 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
Z80/Z80.cs
View File

@@ -1800,7 +1800,7 @@ namespace EightBit
hl2.High = this.MEMPTR.High; hl2.High = this.MEMPTR.High;
} }
private void BlockCompare(Register16 source, Register16 counter) private void BlockCompare(ushort source, Register16 counter)
{ {
var value = this.BusRead(source); var value = this.BusRead(source);
var result = (byte)(this.A - value); var result = (byte)(this.A - value);
@@ -1819,8 +1819,7 @@ namespace EightBit
private void CPI() private void CPI()
{ {
this.BlockCompare(this.HL, this.BC); this.BlockCompare(this.HL.Word++, this.BC);
++this.HL.Word;
++this.MEMPTR.Word; ++this.MEMPTR.Word;
} }
@@ -1832,8 +1831,7 @@ namespace EightBit
private void CPD() private void CPD()
{ {
this.BlockCompare(this.HL, this.BC); this.BlockCompare(this.HL.Word--, this.BC);
--this.HL.Word;
--this.MEMPTR.Word; --this.MEMPTR.Word;
} }
@@ -1843,7 +1841,7 @@ namespace EightBit
return ((this.F & (byte)StatusBits.PF) != 0) && ((this.F & (byte)StatusBits.ZF) == 0); // See CPD return ((this.F & (byte)StatusBits.PF) != 0) && ((this.F & (byte)StatusBits.ZF) == 0); // See CPD
} }
private void BlockLoad(Register16 source, Register16 destination, Register16 counter) private void BlockLoad(ushort source, ushort destination, Register16 counter)
{ {
var value = this.BusRead(source); var value = this.BusRead(source);
this.BusWrite(destination, value); this.BusWrite(destination, value);
@@ -1854,12 +1852,7 @@ namespace EightBit
this.F = SetFlag(this.F, StatusBits.PF, --counter.Word); this.F = SetFlag(this.F, StatusBits.PF, --counter.Word);
} }
private void LDI() private void LDI() => this.BlockLoad(this.HL.Word++, this.DE.Word++, this.BC);
{
this.BlockLoad(this.HL, this.DE, this.BC);
++this.HL.Word;
++this.DE.Word;
}
private bool LDIR() private bool LDIR()
{ {
@@ -1867,12 +1860,7 @@ namespace EightBit
return (this.F & (byte)StatusBits.PF) != 0; // See LDI return (this.F & (byte)StatusBits.PF) != 0; // See LDI
} }
private void LDD() private void LDD() => this.BlockLoad(this.HL.Word--, this.DE.Word--, this.BC);
{
this.BlockLoad(this.HL, this.DE, this.BC);
--this.HL.Word;
--this.DE.Word;
}
private bool LDDR() private bool LDDR()
{ {