6502/EightBitNet
1
0
Fork 0
mirror of https://github.com/MoleskiCoder/EightBitNet.git synced 2026-04-20 21:16:29 +00:00
Code Issues Projects Releases Wiki Activity

A few small consistency updates:

Browse Source 
1) Drop Get/SetPagedByte in favour of normal BusRead/Write
2) Tidy some "using" statements
3) More "expression body" usage, if possible
4) Use field initialisation, rather than construction, if possible
5) Correct IntelProcessor register set/get methods (there were remnants of "copy pasta" code)

Signed-off-by: Adrian Conlon <Adrian.conlon@gmail.com>
This commit is contained in:
Adrian Conlon
2019-02-03 20:29:52 +00:00
parent 0ca57d8641
commit d4a35c402c
10 changed files with 50 additions and 92 deletions
Download Patch File Download Diff File Expand all files Collapse all files
EightBit/Bus.cs
+5 -23
View File
@@ -13,17 +13,8 @@
public event EventHandler<EventArgs> ReadingByte;
public event EventHandler<EventArgs> ReadByte;
public byte Data
{
get { return data; }
set { data = value; }
}
public ushort Address
{
get { return address; }
set { address = value; }
}
public byte Data { get => data; set => data = value; }
public ushort Address { get => address; set => address = value; }
public abstract MemoryMapping Mapping(ushort absolute);
@@ -49,10 +40,7 @@
return Read();
}
public byte Read(byte low, byte high)
{
return Read(Chip.MakeWord(low, high));
}
public byte Read(byte low, byte high) => Read(Chip.MakeWord(low, high));
public void Write()
{
@@ -73,10 +61,7 @@
Write(value);
}
public void Write(byte low, byte high, byte value)
{
Write(Chip.MakeWord(low, high), value);
}
public void Write(byte low, byte high, byte value) => Write(Chip.MakeWord(low, high), value);
public virtual void RaisePOWER() {}
public virtual void LowerPOWER() {}
@@ -103,10 +88,7 @@
protected ref byte Reference() => ref Reference(Address);
protected ref byte Reference(byte low, byte high)
{
return ref Reference(Chip.MakeWord(low, high));
}
protected ref byte Reference(byte low, byte high) => ref Reference(Chip.MakeWord(low, high));
//[[nodiscard]] static std::map<uint16_t, std::vector<uint8_t>> parseHexFile(std::string path);
//void loadHexFile(std::string path);