6502/kickc
1
0
Fork 0
mirror of https://gitlab.com/camelot/kickc.git synced 2024-11-29 02:50:11 +00:00
Code Issues Projects Releases Wiki Activity

Improved inline ASM checking

Browse Source
This commit is contained in:
jespergravgaard 2023-04-10 11:49:51 +02:00
parent 9dc17caab2
commit 18f6923e4f
1 changed files with 17 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

33
src/main/java/dk/camelot64/kickc/passes/Pass3AssertConstants.java
View File

@ -2,12 +2,12 @@ package dk.camelot64.kickc.passes;
import dk.camelot64.kickc.model.CompileError; import dk.camelot64.kickc.model.CompileError;
import dk.camelot64.kickc.model.Program; import dk.camelot64.kickc.model.Program;
import dk.camelot64.kickc.model.statements.Statement;
import dk.camelot64.kickc.model.statements.StatementAsm; import dk.camelot64.kickc.model.statements.StatementAsm;
import dk.camelot64.kickc.model.statements.StatementKickAsm; import dk.camelot64.kickc.model.statements.StatementKickAsm;
import dk.camelot64.kickc.model.symbols.Procedure; import dk.camelot64.kickc.model.symbols.Procedure;
import dk.camelot64.kickc.model.symbols.Symbol; import dk.camelot64.kickc.model.symbols.Symbol;
import dk.camelot64.kickc.model.symbols.Variable; import dk.camelot64.kickc.model.symbols.Variable;
import dk.camelot64.kickc.model.values.ConstantRef;
import dk.camelot64.kickc.model.values.ConstantValue; import dk.camelot64.kickc.model.values.ConstantValue;
import dk.camelot64.kickc.model.values.RValue; import dk.camelot64.kickc.model.values.RValue;
import dk.camelot64.kickc.model.values.SymbolRef; import dk.camelot64.kickc.model.values.SymbolRef;
@ -42,29 +42,30 @@ public class Pass3AssertConstants extends Pass2SsaAssertion {
} }
List<SymbolRef> uses = statementKickAsm.getUses(); List<SymbolRef> uses = statementKickAsm.getUses();
for(SymbolRef use : uses) { for(SymbolRef use : uses) {
if(!(use instanceof ConstantRef)) { checkReference(statement, use);
throw new CompileError("Inline KickAsm reference is not constant " + use, statement);
}
} }
} else if(statement instanceof StatementAsm statementAsm) { } else if(statement instanceof StatementAsm statementAsm) {
Map<String, SymbolRef> referenced = statementAsm.getReferenced(); Map<String, SymbolRef> referenced = statementAsm.getReferenced();
for(String label : referenced.keySet()) { for(String label : referenced.keySet()) {
SymbolRef symbolRef = referenced.get(label); SymbolRef symbolRef = referenced.get(label);
Symbol symbol = getScope().getSymbol(symbolRef); checkReference(statement, symbolRef);
if(symbol instanceof Procedure)
// Referencing procedures are fine!
continue;
else if(symbol instanceof Variable && ((Variable) symbol).isKindConstant())
// Referencing constants are fine!
continue;
else if(symbol instanceof Variable && ((Variable) symbol).isKindLoadStore())
// Referencing load/store is fine!
continue;
else
throw new CompileError("Inline ASM reference is not constant " + label, statement);
} }
} }
} }
} }
private void checkReference(Statement statement, SymbolRef symbolRef) {
Symbol symbol = getScope().getSymbol(symbolRef);
if(symbol instanceof Procedure)
// Referencing procedures are fine!
return;
else if(symbol instanceof Variable && ((Variable) symbol).isKindConstant())
// Referencing constants are fine!
return;
else if(symbol instanceof Variable && ((Variable) symbol).isKindLoadStore())
// Referencing load/store is fine!
return;
else
throw new CompileError("Inline ASM reference is not constant " + symbolRef, statement);
}
} }