Reenable use of TBAA during CodeGen
We had disabled use of TBAA during CodeGen (even when otherwise using AA)
because the ptrtoint/inttoptr used by CGP for address sinking caused BasicAA to
miss basic type punning that it should catch (and, thus, we'd fail to override
TBAA when we should).
However, when AA is in use during CodeGen, CGP now uses normal GEPs and
bitcasts, instead of ptrtoint/inttoptr, when doing address sinking. As a
result, BasicAA should be able to make us do the right thing in the face of
type-punning, and it seems safe to enable use of TBAA again. self-hosting seems
fine on PPC64/Linux on the P7, with TBAA enabled and -misched=shuffle.
Note: We still don't update TBAA when merging stack slots, although because
BasicAA should now catch all such cases, this is no longer a blocking issue.
Nevertheless, I plan to commit code to deal with this properly in the near
future.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206093 91177308-0d34-0410-b5e6-96231b3b80d8
2014-04-12 01:26:00 +00:00
|
|
|
; RUN: llc -enable-misched -misched=shuffle -enable-aa-sched-mi -use-tbaa-in-sched-mi=0 -post-RA-scheduler=0 -mcpu=ppc64 < %s | FileCheck %s
|
2014-01-25 20:16:36 +00:00
|
|
|
|
|
|
|
|
; REQUIRES: asserts
|
|
|
|
|
; -misched=shuffle is NDEBUG only!
|
|
|
|
|
|
|
|
|
|
target datalayout = "E-m:e-i64:64-n32:64"
|
|
|
|
|
target triple = "powerpc64-unknown-linux-gnu"
|
|
|
|
|
|
|
|
|
|
%"class.llvm::MCOperand" = type { i8, %union.anon.110 }
|
|
|
|
|
%union.anon.110 = type { i64 }
|
|
|
|
|
|
|
|
|
|
define void @foo(i32 %v) {
|
|
|
|
|
entry:
|
|
|
|
|
%MCOp = alloca %"class.llvm::MCOperand", align 8
|
|
|
|
|
br label %next
|
|
|
|
|
|
|
|
|
|
; CHECK-LABEL: @foo
|
|
|
|
|
|
|
|
|
|
next:
|
|
|
|
|
%sunkaddr18 = ptrtoint %"class.llvm::MCOperand"* %MCOp to i64
|
|
|
|
|
%sunkaddr19 = add i64 %sunkaddr18, 8
|
|
|
|
|
%sunkaddr20 = inttoptr i64 %sunkaddr19 to double*
|
|
|
|
|
store double 0.000000e+00, double* %sunkaddr20, align 8, !tbaa !1
|
|
|
|
|
%sunkaddr21 = ptrtoint %"class.llvm::MCOperand"* %MCOp to i64
|
|
|
|
|
%sunkaddr22 = add i64 %sunkaddr21, 8
|
|
|
|
|
%sunkaddr23 = inttoptr i64 %sunkaddr22 to i32*
|
|
|
|
|
store i32 %v, i32* %sunkaddr23, align 8, !tbaa !2
|
|
|
|
|
ret void
|
|
|
|
|
|
|
|
|
|
; Make sure that the 64-bit store comes first, regardless of what TBAA says
|
|
|
|
|
; about the two not aliasing!
|
|
|
|
|
; CHECK: li [[REG:[0-9]+]], 0
|
|
|
|
|
; CHECK: std [[REG]], -[[OFF:[0-9]+]](1)
|
|
|
|
|
; CHECK: stw 3, -[[OFF]](1)
|
|
|
|
|
; CHECK: blr
|
|
|
|
|
}
|
|
|
|
|
|
IR: Make metadata typeless in assembly
Now that `Metadata` is typeless, reflect that in the assembly. These
are the matching assembly changes for the metadata/value split in
r223802.
- Only use the `metadata` type when referencing metadata from a call
intrinsic -- i.e., only when it's used as a `Value`.
- Stop pretending that `ValueAsMetadata` is wrapped in an `MDNode`
when referencing it from call intrinsics.
So, assembly like this:
define @foo(i32 %v) {
call void @llvm.foo(metadata !{i32 %v}, metadata !0)
call void @llvm.foo(metadata !{i32 7}, metadata !0)
call void @llvm.foo(metadata !1, metadata !0)
call void @llvm.foo(metadata !3, metadata !0)
call void @llvm.foo(metadata !{metadata !3}, metadata !0)
ret void, !bar !2
}
!0 = metadata !{metadata !2}
!1 = metadata !{i32* @global}
!2 = metadata !{metadata !3}
!3 = metadata !{}
turns into this:
define @foo(i32 %v) {
call void @llvm.foo(metadata i32 %v, metadata !0)
call void @llvm.foo(metadata i32 7, metadata !0)
call void @llvm.foo(metadata i32* @global, metadata !0)
call void @llvm.foo(metadata !3, metadata !0)
call void @llvm.foo(metadata !{!3}, metadata !0)
ret void, !bar !2
}
!0 = !{!2}
!1 = !{i32* @global}
!2 = !{!3}
!3 = !{}
I wrote an upgrade script that handled almost all of the tests in llvm
and many of the tests in cfe (even handling many `CHECK` lines). I've
attached it (or will attach it in a moment if you're speedy) to PR21532
to help everyone update their out-of-tree testcases.
This is part of PR21532.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@224257 91177308-0d34-0410-b5e6-96231b3b80d8
2014-12-15 19:07:53 +00:00
|
|
|
!0 = !{ !"root" }
|
|
|
|
|
!1 = !{ !"set1", !0 }
|
|
|
|
|
!2 = !{ !"set2", !0 }
|
2014-01-25 20:16:36 +00:00
|
|
|
|
