2014-04-01 21:49:04 +00:00
|
|
|
//===-- llvm/CodeGen/DebugLocEntry.h - Entry in debug_loc list -*- C++ -*--===//
|
|
|
|
//
|
|
|
|
// The LLVM Compiler Infrastructure
|
|
|
|
//
|
|
|
|
// This file is distributed under the University of Illinois Open Source
|
|
|
|
// License. See LICENSE.TXT for details.
|
|
|
|
//
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
|
2014-08-13 16:26:38 +00:00
|
|
|
#ifndef LLVM_LIB_CODEGEN_ASMPRINTER_DEBUGLOCENTRY_H
|
|
|
|
#define LLVM_LIB_CODEGEN_ASMPRINTER_DEBUGLOCENTRY_H
|
2014-04-01 21:49:04 +00:00
|
|
|
#include "llvm/IR/Constants.h"
|
2014-08-01 22:11:58 +00:00
|
|
|
#include "llvm/IR/DebugInfo.h"
|
2014-04-01 21:49:04 +00:00
|
|
|
#include "llvm/MC/MachineLocation.h"
|
|
|
|
#include "llvm/MC/MCSymbol.h"
|
|
|
|
|
|
|
|
namespace llvm {
|
|
|
|
class MDNode;
|
|
|
|
/// \brief This struct describes location entries emitted in the .debug_loc
|
|
|
|
/// section.
|
|
|
|
class DebugLocEntry {
|
|
|
|
// Begin and end symbols for the address range that this location is valid.
|
|
|
|
const MCSymbol *Begin;
|
|
|
|
const MCSymbol *End;
|
|
|
|
|
2014-04-27 18:25:40 +00:00
|
|
|
public:
|
|
|
|
/// A single location or constant.
|
|
|
|
struct Value {
|
Move the complex address expression out of DIVariable and into an extra
argument of the llvm.dbg.declare/llvm.dbg.value intrinsics.
Previously, DIVariable was a variable-length field that has an optional
reference to a Metadata array consisting of a variable number of
complex address expressions. In the case of OpPiece expressions this is
wasting a lot of storage in IR, because when an aggregate type is, e.g.,
SROA'd into all of its n individual members, the IR will contain n copies
of the DIVariable, all alike, only differing in the complex address
reference at the end.
By making the complex address into an extra argument of the
dbg.value/dbg.declare intrinsics, all of the pieces can reference the
same variable and the complex address expressions can be uniqued across
the CU, too.
Down the road, this will allow us to move other flags, such as
"indirection" out of the DIVariable, too.
The new intrinsics look like this:
declare void @llvm.dbg.declare(metadata %storage, metadata %var, metadata %expr)
declare void @llvm.dbg.value(metadata %storage, i64 %offset, metadata %var, metadata %expr)
This patch adds a new LLVM-local tag to DIExpressions, so we can detect
and pretty-print DIExpression metadata nodes.
What this patch doesn't do:
This patch does not touch the "Indirect" field in DIVariable; but moving
that into the expression would be a natural next step.
http://reviews.llvm.org/D4919
rdar://problem/17994491
Thanks to dblaikie and dexonsmith for reviewing this patch!
Note: I accidentally committed a bogus older version of this patch previously.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@218787 91177308-0d34-0410-b5e6-96231b3b80d8
2014-10-01 18:55:02 +00:00
|
|
|
Value(const MDNode *Var, const MDNode *Expr, int64_t i)
|
|
|
|
: Variable(Var), Expression(Expr), EntryKind(E_Integer) {
|
2014-04-27 18:25:40 +00:00
|
|
|
Constant.Int = i;
|
|
|
|
}
|
Move the complex address expression out of DIVariable and into an extra
argument of the llvm.dbg.declare/llvm.dbg.value intrinsics.
Previously, DIVariable was a variable-length field that has an optional
reference to a Metadata array consisting of a variable number of
complex address expressions. In the case of OpPiece expressions this is
wasting a lot of storage in IR, because when an aggregate type is, e.g.,
SROA'd into all of its n individual members, the IR will contain n copies
of the DIVariable, all alike, only differing in the complex address
reference at the end.
By making the complex address into an extra argument of the
dbg.value/dbg.declare intrinsics, all of the pieces can reference the
same variable and the complex address expressions can be uniqued across
the CU, too.
Down the road, this will allow us to move other flags, such as
"indirection" out of the DIVariable, too.
The new intrinsics look like this:
declare void @llvm.dbg.declare(metadata %storage, metadata %var, metadata %expr)
declare void @llvm.dbg.value(metadata %storage, i64 %offset, metadata %var, metadata %expr)
This patch adds a new LLVM-local tag to DIExpressions, so we can detect
and pretty-print DIExpression metadata nodes.
What this patch doesn't do:
This patch does not touch the "Indirect" field in DIVariable; but moving
that into the expression would be a natural next step.
http://reviews.llvm.org/D4919
rdar://problem/17994491
Thanks to dblaikie and dexonsmith for reviewing this patch!
Note: I accidentally committed a bogus older version of this patch previously.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@218787 91177308-0d34-0410-b5e6-96231b3b80d8
2014-10-01 18:55:02 +00:00
|
|
|
Value(const MDNode *Var, const MDNode *Expr, const ConstantFP *CFP)
|
|
|
|
: Variable(Var), Expression(Expr), EntryKind(E_ConstantFP) {
|
2014-04-27 18:25:40 +00:00
|
|
|
Constant.CFP = CFP;
|
|
|
|
}
|
Move the complex address expression out of DIVariable and into an extra
argument of the llvm.dbg.declare/llvm.dbg.value intrinsics.
Previously, DIVariable was a variable-length field that has an optional
reference to a Metadata array consisting of a variable number of
complex address expressions. In the case of OpPiece expressions this is
wasting a lot of storage in IR, because when an aggregate type is, e.g.,
SROA'd into all of its n individual members, the IR will contain n copies
of the DIVariable, all alike, only differing in the complex address
reference at the end.
By making the complex address into an extra argument of the
dbg.value/dbg.declare intrinsics, all of the pieces can reference the
same variable and the complex address expressions can be uniqued across
the CU, too.
Down the road, this will allow us to move other flags, such as
"indirection" out of the DIVariable, too.
The new intrinsics look like this:
declare void @llvm.dbg.declare(metadata %storage, metadata %var, metadata %expr)
declare void @llvm.dbg.value(metadata %storage, i64 %offset, metadata %var, metadata %expr)
This patch adds a new LLVM-local tag to DIExpressions, so we can detect
and pretty-print DIExpression metadata nodes.
What this patch doesn't do:
This patch does not touch the "Indirect" field in DIVariable; but moving
that into the expression would be a natural next step.
http://reviews.llvm.org/D4919
rdar://problem/17994491
Thanks to dblaikie and dexonsmith for reviewing this patch!
Note: I accidentally committed a bogus older version of this patch previously.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@218787 91177308-0d34-0410-b5e6-96231b3b80d8
2014-10-01 18:55:02 +00:00
|
|
|
Value(const MDNode *Var, const MDNode *Expr, const ConstantInt *CIP)
|
|
|
|
: Variable(Var), Expression(Expr), EntryKind(E_ConstantInt) {
|
2014-04-27 18:25:40 +00:00
|
|
|
Constant.CIP = CIP;
|
|
|
|
}
|
Move the complex address expression out of DIVariable and into an extra
argument of the llvm.dbg.declare/llvm.dbg.value intrinsics.
Previously, DIVariable was a variable-length field that has an optional
reference to a Metadata array consisting of a variable number of
complex address expressions. In the case of OpPiece expressions this is
wasting a lot of storage in IR, because when an aggregate type is, e.g.,
SROA'd into all of its n individual members, the IR will contain n copies
of the DIVariable, all alike, only differing in the complex address
reference at the end.
By making the complex address into an extra argument of the
dbg.value/dbg.declare intrinsics, all of the pieces can reference the
same variable and the complex address expressions can be uniqued across
the CU, too.
Down the road, this will allow us to move other flags, such as
"indirection" out of the DIVariable, too.
The new intrinsics look like this:
declare void @llvm.dbg.declare(metadata %storage, metadata %var, metadata %expr)
declare void @llvm.dbg.value(metadata %storage, i64 %offset, metadata %var, metadata %expr)
This patch adds a new LLVM-local tag to DIExpressions, so we can detect
and pretty-print DIExpression metadata nodes.
What this patch doesn't do:
This patch does not touch the "Indirect" field in DIVariable; but moving
that into the expression would be a natural next step.
http://reviews.llvm.org/D4919
rdar://problem/17994491
Thanks to dblaikie and dexonsmith for reviewing this patch!
Note: I accidentally committed a bogus older version of this patch previously.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@218787 91177308-0d34-0410-b5e6-96231b3b80d8
2014-10-01 18:55:02 +00:00
|
|
|
Value(const MDNode *Var, const MDNode *Expr, MachineLocation Loc)
|
|
|
|
: Variable(Var), Expression(Expr), EntryKind(E_Location), Loc(Loc) {
|
|
|
|
assert(DIVariable(Var).Verify());
|
|
|
|
assert(DIExpression(Expr).Verify());
|
2014-04-27 18:25:40 +00:00
|
|
|
}
|
2014-04-01 21:49:04 +00:00
|
|
|
|
2014-04-27 18:25:40 +00:00
|
|
|
// The variable to which this location entry corresponds.
|
|
|
|
const MDNode *Variable;
|
2014-04-01 21:49:04 +00:00
|
|
|
|
Move the complex address expression out of DIVariable and into an extra
argument of the llvm.dbg.declare/llvm.dbg.value intrinsics.
Previously, DIVariable was a variable-length field that has an optional
reference to a Metadata array consisting of a variable number of
complex address expressions. In the case of OpPiece expressions this is
wasting a lot of storage in IR, because when an aggregate type is, e.g.,
SROA'd into all of its n individual members, the IR will contain n copies
of the DIVariable, all alike, only differing in the complex address
reference at the end.
By making the complex address into an extra argument of the
dbg.value/dbg.declare intrinsics, all of the pieces can reference the
same variable and the complex address expressions can be uniqued across
the CU, too.
Down the road, this will allow us to move other flags, such as
"indirection" out of the DIVariable, too.
The new intrinsics look like this:
declare void @llvm.dbg.declare(metadata %storage, metadata %var, metadata %expr)
declare void @llvm.dbg.value(metadata %storage, i64 %offset, metadata %var, metadata %expr)
This patch adds a new LLVM-local tag to DIExpressions, so we can detect
and pretty-print DIExpression metadata nodes.
What this patch doesn't do:
This patch does not touch the "Indirect" field in DIVariable; but moving
that into the expression would be a natural next step.
http://reviews.llvm.org/D4919
rdar://problem/17994491
Thanks to dblaikie and dexonsmith for reviewing this patch!
Note: I accidentally committed a bogus older version of this patch previously.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@218787 91177308-0d34-0410-b5e6-96231b3b80d8
2014-10-01 18:55:02 +00:00
|
|
|
// Any complex address location expression for this Value.
|
|
|
|
const MDNode *Expression;
|
|
|
|
|
2014-04-27 18:25:40 +00:00
|
|
|
// Type of entry that this represents.
|
|
|
|
enum EntryType { E_Location, E_Integer, E_ConstantFP, E_ConstantInt };
|
|
|
|
enum EntryType EntryKind;
|
2014-04-01 21:49:04 +00:00
|
|
|
|
2014-04-27 18:25:40 +00:00
|
|
|
// Either a constant,
|
|
|
|
union {
|
|
|
|
int64_t Int;
|
|
|
|
const ConstantFP *CFP;
|
|
|
|
const ConstantInt *CIP;
|
|
|
|
} Constant;
|
2014-04-01 21:49:04 +00:00
|
|
|
|
2014-04-27 18:25:40 +00:00
|
|
|
// Or a location in the machine frame.
|
|
|
|
MachineLocation Loc;
|
2014-04-01 21:49:04 +00:00
|
|
|
|
2014-04-27 18:25:40 +00:00
|
|
|
bool isLocation() const { return EntryKind == E_Location; }
|
|
|
|
bool isInt() const { return EntryKind == E_Integer; }
|
|
|
|
bool isConstantFP() const { return EntryKind == E_ConstantFP; }
|
|
|
|
bool isConstantInt() const { return EntryKind == E_ConstantInt; }
|
|
|
|
int64_t getInt() const { return Constant.Int; }
|
|
|
|
const ConstantFP *getConstantFP() const { return Constant.CFP; }
|
|
|
|
const ConstantInt *getConstantInt() const { return Constant.CIP; }
|
|
|
|
MachineLocation getLoc() const { return Loc; }
|
2014-08-11 23:22:59 +00:00
|
|
|
const MDNode *getVariableNode() const { return Variable; }
|
|
|
|
DIVariable getVariable() const { return DIVariable(Variable); }
|
Move the complex address expression out of DIVariable and into an extra
argument of the llvm.dbg.declare/llvm.dbg.value intrinsics.
Previously, DIVariable was a variable-length field that has an optional
reference to a Metadata array consisting of a variable number of
complex address expressions. In the case of OpPiece expressions this is
wasting a lot of storage in IR, because when an aggregate type is, e.g.,
SROA'd into all of its n individual members, the IR will contain n copies
of the DIVariable, all alike, only differing in the complex address
reference at the end.
By making the complex address into an extra argument of the
dbg.value/dbg.declare intrinsics, all of the pieces can reference the
same variable and the complex address expressions can be uniqued across
the CU, too.
Down the road, this will allow us to move other flags, such as
"indirection" out of the DIVariable, too.
The new intrinsics look like this:
declare void @llvm.dbg.declare(metadata %storage, metadata %var, metadata %expr)
declare void @llvm.dbg.value(metadata %storage, i64 %offset, metadata %var, metadata %expr)
This patch adds a new LLVM-local tag to DIExpressions, so we can detect
and pretty-print DIExpression metadata nodes.
What this patch doesn't do:
This patch does not touch the "Indirect" field in DIVariable; but moving
that into the expression would be a natural next step.
http://reviews.llvm.org/D4919
rdar://problem/17994491
Thanks to dblaikie and dexonsmith for reviewing this patch!
Note: I accidentally committed a bogus older version of this patch previously.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@218787 91177308-0d34-0410-b5e6-96231b3b80d8
2014-10-01 18:55:02 +00:00
|
|
|
bool isVariablePiece() const { return getExpression().isVariablePiece(); }
|
|
|
|
DIExpression getExpression() const { return DIExpression(Expression); }
|
2014-08-11 22:52:56 +00:00
|
|
|
friend bool operator==(const Value &, const Value &);
|
|
|
|
friend bool operator<(const Value &, const Value &);
|
2014-04-27 18:25:40 +00:00
|
|
|
};
|
2014-08-11 22:52:56 +00:00
|
|
|
|
2014-04-27 18:25:40 +00:00
|
|
|
private:
|
2014-08-11 21:06:03 +00:00
|
|
|
/// A nonempty list of locations/constants belonging to this entry,
|
|
|
|
/// sorted by offset.
|
2014-04-27 18:25:40 +00:00
|
|
|
SmallVector<Value, 1> Values;
|
|
|
|
|
2014-04-01 21:49:04 +00:00
|
|
|
public:
|
2014-08-05 23:14:16 +00:00
|
|
|
DebugLocEntry(const MCSymbol *B, const MCSymbol *E, Value Val)
|
|
|
|
: Begin(B), End(E) {
|
2014-04-27 18:25:40 +00:00
|
|
|
Values.push_back(std::move(Val));
|
2014-04-01 21:49:04 +00:00
|
|
|
}
|
|
|
|
|
2014-08-11 20:59:28 +00:00
|
|
|
/// \brief If this and Next are describing different pieces of the same
|
|
|
|
// variable, merge them by appending Next's values to the current
|
|
|
|
// list of values.
|
|
|
|
// Return true if the merge was successful.
|
|
|
|
bool MergeValues(const DebugLocEntry &Next) {
|
Move the complex address expression out of DIVariable and into an extra
argument of the llvm.dbg.declare/llvm.dbg.value intrinsics.
Previously, DIVariable was a variable-length field that has an optional
reference to a Metadata array consisting of a variable number of
complex address expressions. In the case of OpPiece expressions this is
wasting a lot of storage in IR, because when an aggregate type is, e.g.,
SROA'd into all of its n individual members, the IR will contain n copies
of the DIVariable, all alike, only differing in the complex address
reference at the end.
By making the complex address into an extra argument of the
dbg.value/dbg.declare intrinsics, all of the pieces can reference the
same variable and the complex address expressions can be uniqued across
the CU, too.
Down the road, this will allow us to move other flags, such as
"indirection" out of the DIVariable, too.
The new intrinsics look like this:
declare void @llvm.dbg.declare(metadata %storage, metadata %var, metadata %expr)
declare void @llvm.dbg.value(metadata %storage, i64 %offset, metadata %var, metadata %expr)
This patch adds a new LLVM-local tag to DIExpressions, so we can detect
and pretty-print DIExpression metadata nodes.
What this patch doesn't do:
This patch does not touch the "Indirect" field in DIVariable; but moving
that into the expression would be a natural next step.
http://reviews.llvm.org/D4919
rdar://problem/17994491
Thanks to dblaikie and dexonsmith for reviewing this patch!
Note: I accidentally committed a bogus older version of this patch previously.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@218787 91177308-0d34-0410-b5e6-96231b3b80d8
2014-10-01 18:55:02 +00:00
|
|
|
if (Begin == Next.Begin) {
|
|
|
|
DIExpression Expr(Values[0].Expression);
|
2014-08-01 22:11:58 +00:00
|
|
|
DIVariable Var(Values[0].Variable);
|
Move the complex address expression out of DIVariable and into an extra
argument of the llvm.dbg.declare/llvm.dbg.value intrinsics.
Previously, DIVariable was a variable-length field that has an optional
reference to a Metadata array consisting of a variable number of
complex address expressions. In the case of OpPiece expressions this is
wasting a lot of storage in IR, because when an aggregate type is, e.g.,
SROA'd into all of its n individual members, the IR will contain n copies
of the DIVariable, all alike, only differing in the complex address
reference at the end.
By making the complex address into an extra argument of the
dbg.value/dbg.declare intrinsics, all of the pieces can reference the
same variable and the complex address expressions can be uniqued across
the CU, too.
Down the road, this will allow us to move other flags, such as
"indirection" out of the DIVariable, too.
The new intrinsics look like this:
declare void @llvm.dbg.declare(metadata %storage, metadata %var, metadata %expr)
declare void @llvm.dbg.value(metadata %storage, i64 %offset, metadata %var, metadata %expr)
This patch adds a new LLVM-local tag to DIExpressions, so we can detect
and pretty-print DIExpression metadata nodes.
What this patch doesn't do:
This patch does not touch the "Indirect" field in DIVariable; but moving
that into the expression would be a natural next step.
http://reviews.llvm.org/D4919
rdar://problem/17994491
Thanks to dblaikie and dexonsmith for reviewing this patch!
Note: I accidentally committed a bogus older version of this patch previously.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@218787 91177308-0d34-0410-b5e6-96231b3b80d8
2014-10-01 18:55:02 +00:00
|
|
|
DIExpression NextExpr(Next.Values[0].Expression);
|
2014-08-01 22:11:58 +00:00
|
|
|
DIVariable NextVar(Next.Values[0].Variable);
|
Move the complex address expression out of DIVariable and into an extra
argument of the llvm.dbg.declare/llvm.dbg.value intrinsics.
Previously, DIVariable was a variable-length field that has an optional
reference to a Metadata array consisting of a variable number of
complex address expressions. In the case of OpPiece expressions this is
wasting a lot of storage in IR, because when an aggregate type is, e.g.,
SROA'd into all of its n individual members, the IR will contain n copies
of the DIVariable, all alike, only differing in the complex address
reference at the end.
By making the complex address into an extra argument of the
dbg.value/dbg.declare intrinsics, all of the pieces can reference the
same variable and the complex address expressions can be uniqued across
the CU, too.
Down the road, this will allow us to move other flags, such as
"indirection" out of the DIVariable, too.
The new intrinsics look like this:
declare void @llvm.dbg.declare(metadata %storage, metadata %var, metadata %expr)
declare void @llvm.dbg.value(metadata %storage, i64 %offset, metadata %var, metadata %expr)
This patch adds a new LLVM-local tag to DIExpressions, so we can detect
and pretty-print DIExpression metadata nodes.
What this patch doesn't do:
This patch does not touch the "Indirect" field in DIVariable; but moving
that into the expression would be a natural next step.
http://reviews.llvm.org/D4919
rdar://problem/17994491
Thanks to dblaikie and dexonsmith for reviewing this patch!
Note: I accidentally committed a bogus older version of this patch previously.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@218787 91177308-0d34-0410-b5e6-96231b3b80d8
2014-10-01 18:55:02 +00:00
|
|
|
if (Var == NextVar && Expr.isVariablePiece() &&
|
|
|
|
NextExpr.isVariablePiece()) {
|
2014-08-11 21:06:00 +00:00
|
|
|
addValues(Next.Values);
|
2014-08-01 22:11:58 +00:00
|
|
|
End = Next.End;
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
}
|
2014-08-11 20:59:28 +00:00
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
|
|
|
/// \brief Attempt to merge this DebugLocEntry with Next and return
|
|
|
|
/// true if the merge was successful. Entries can be merged if they
|
|
|
|
/// share the same Loc/Constant and if Next immediately follows this
|
|
|
|
/// Entry.
|
|
|
|
bool MergeRanges(const DebugLocEntry &Next) {
|
2014-08-01 22:11:58 +00:00
|
|
|
// If this and Next are describing the same variable, merge them.
|
2014-04-27 18:25:40 +00:00
|
|
|
if ((End == Next.Begin && Values == Next.Values)) {
|
2014-04-01 23:19:23 +00:00
|
|
|
End = Next.End;
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
return false;
|
2014-04-01 21:49:04 +00:00
|
|
|
}
|
2014-08-01 22:11:58 +00:00
|
|
|
|
2014-04-01 21:49:04 +00:00
|
|
|
const MCSymbol *getBeginSym() const { return Begin; }
|
|
|
|
const MCSymbol *getEndSym() const { return End; }
|
2014-08-27 05:25:00 +00:00
|
|
|
ArrayRef<Value> getValues() const { return Values; }
|
2014-08-11 21:06:00 +00:00
|
|
|
void addValues(ArrayRef<DebugLocEntry::Value> Vals) {
|
|
|
|
Values.append(Vals.begin(), Vals.end());
|
2014-08-11 21:05:55 +00:00
|
|
|
sortUniqueValues();
|
2014-08-11 21:06:00 +00:00
|
|
|
assert(std::all_of(Values.begin(), Values.end(), [](DebugLocEntry::Value V){
|
2014-08-11 23:22:59 +00:00
|
|
|
return V.isVariablePiece();
|
2014-08-11 21:06:00 +00:00
|
|
|
}) && "value must be a piece");
|
2014-08-11 21:05:55 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
// Sort the pieces by offset.
|
|
|
|
// Remove any duplicate entries by dropping all but the first.
|
|
|
|
void sortUniqueValues() {
|
|
|
|
std::sort(Values.begin(), Values.end());
|
2014-08-12 01:07:53 +00:00
|
|
|
Values.erase(std::unique(Values.begin(), Values.end(),
|
|
|
|
[](const Value &A, const Value &B) {
|
Move the complex address expression out of DIVariable and into an extra
argument of the llvm.dbg.declare/llvm.dbg.value intrinsics.
Previously, DIVariable was a variable-length field that has an optional
reference to a Metadata array consisting of a variable number of
complex address expressions. In the case of OpPiece expressions this is
wasting a lot of storage in IR, because when an aggregate type is, e.g.,
SROA'd into all of its n individual members, the IR will contain n copies
of the DIVariable, all alike, only differing in the complex address
reference at the end.
By making the complex address into an extra argument of the
dbg.value/dbg.declare intrinsics, all of the pieces can reference the
same variable and the complex address expressions can be uniqued across
the CU, too.
Down the road, this will allow us to move other flags, such as
"indirection" out of the DIVariable, too.
The new intrinsics look like this:
declare void @llvm.dbg.declare(metadata %storage, metadata %var, metadata %expr)
declare void @llvm.dbg.value(metadata %storage, i64 %offset, metadata %var, metadata %expr)
This patch adds a new LLVM-local tag to DIExpressions, so we can detect
and pretty-print DIExpression metadata nodes.
What this patch doesn't do:
This patch does not touch the "Indirect" field in DIVariable; but moving
that into the expression would be a natural next step.
http://reviews.llvm.org/D4919
rdar://problem/17994491
Thanks to dblaikie and dexonsmith for reviewing this patch!
Note: I accidentally committed a bogus older version of this patch previously.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@218787 91177308-0d34-0410-b5e6-96231b3b80d8
2014-10-01 18:55:02 +00:00
|
|
|
return A.getVariable() == B.getVariable() &&
|
|
|
|
A.getExpression() == B.getExpression();
|
|
|
|
}),
|
|
|
|
Values.end());
|
2014-08-01 22:11:58 +00:00
|
|
|
}
|
2014-04-01 21:49:04 +00:00
|
|
|
};
|
|
|
|
|
2014-08-11 22:52:56 +00:00
|
|
|
/// Compare two Values for equality.
|
|
|
|
inline bool operator==(const DebugLocEntry::Value &A,
|
|
|
|
const DebugLocEntry::Value &B) {
|
|
|
|
if (A.EntryKind != B.EntryKind)
|
|
|
|
return false;
|
|
|
|
|
Move the complex address expression out of DIVariable and into an extra
argument of the llvm.dbg.declare/llvm.dbg.value intrinsics.
Previously, DIVariable was a variable-length field that has an optional
reference to a Metadata array consisting of a variable number of
complex address expressions. In the case of OpPiece expressions this is
wasting a lot of storage in IR, because when an aggregate type is, e.g.,
SROA'd into all of its n individual members, the IR will contain n copies
of the DIVariable, all alike, only differing in the complex address
reference at the end.
By making the complex address into an extra argument of the
dbg.value/dbg.declare intrinsics, all of the pieces can reference the
same variable and the complex address expressions can be uniqued across
the CU, too.
Down the road, this will allow us to move other flags, such as
"indirection" out of the DIVariable, too.
The new intrinsics look like this:
declare void @llvm.dbg.declare(metadata %storage, metadata %var, metadata %expr)
declare void @llvm.dbg.value(metadata %storage, i64 %offset, metadata %var, metadata %expr)
This patch adds a new LLVM-local tag to DIExpressions, so we can detect
and pretty-print DIExpression metadata nodes.
What this patch doesn't do:
This patch does not touch the "Indirect" field in DIVariable; but moving
that into the expression would be a natural next step.
http://reviews.llvm.org/D4919
rdar://problem/17994491
Thanks to dblaikie and dexonsmith for reviewing this patch!
Note: I accidentally committed a bogus older version of this patch previously.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@218787 91177308-0d34-0410-b5e6-96231b3b80d8
2014-10-01 18:55:02 +00:00
|
|
|
if (A.Expression != B.Expression)
|
|
|
|
return false;
|
|
|
|
|
|
|
|
if (A.Variable != B.Variable)
|
2014-08-11 22:52:56 +00:00
|
|
|
return false;
|
|
|
|
|
|
|
|
switch (A.EntryKind) {
|
|
|
|
case DebugLocEntry::Value::E_Location:
|
|
|
|
return A.Loc == B.Loc;
|
|
|
|
case DebugLocEntry::Value::E_Integer:
|
|
|
|
return A.Constant.Int == B.Constant.Int;
|
|
|
|
case DebugLocEntry::Value::E_ConstantFP:
|
|
|
|
return A.Constant.CFP == B.Constant.CFP;
|
|
|
|
case DebugLocEntry::Value::E_ConstantInt:
|
|
|
|
return A.Constant.CIP == B.Constant.CIP;
|
|
|
|
}
|
|
|
|
llvm_unreachable("unhandled EntryKind");
|
|
|
|
}
|
|
|
|
|
|
|
|
/// Compare two pieces based on their offset.
|
|
|
|
inline bool operator<(const DebugLocEntry::Value &A,
|
|
|
|
const DebugLocEntry::Value &B) {
|
Move the complex address expression out of DIVariable and into an extra
argument of the llvm.dbg.declare/llvm.dbg.value intrinsics.
Previously, DIVariable was a variable-length field that has an optional
reference to a Metadata array consisting of a variable number of
complex address expressions. In the case of OpPiece expressions this is
wasting a lot of storage in IR, because when an aggregate type is, e.g.,
SROA'd into all of its n individual members, the IR will contain n copies
of the DIVariable, all alike, only differing in the complex address
reference at the end.
By making the complex address into an extra argument of the
dbg.value/dbg.declare intrinsics, all of the pieces can reference the
same variable and the complex address expressions can be uniqued across
the CU, too.
Down the road, this will allow us to move other flags, such as
"indirection" out of the DIVariable, too.
The new intrinsics look like this:
declare void @llvm.dbg.declare(metadata %storage, metadata %var, metadata %expr)
declare void @llvm.dbg.value(metadata %storage, i64 %offset, metadata %var, metadata %expr)
This patch adds a new LLVM-local tag to DIExpressions, so we can detect
and pretty-print DIExpression metadata nodes.
What this patch doesn't do:
This patch does not touch the "Indirect" field in DIVariable; but moving
that into the expression would be a natural next step.
http://reviews.llvm.org/D4919
rdar://problem/17994491
Thanks to dblaikie and dexonsmith for reviewing this patch!
Note: I accidentally committed a bogus older version of this patch previously.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@218787 91177308-0d34-0410-b5e6-96231b3b80d8
2014-10-01 18:55:02 +00:00
|
|
|
return A.getExpression().getPieceOffset() <
|
|
|
|
B.getExpression().getPieceOffset();
|
2014-08-11 22:52:56 +00:00
|
|
|
}
|
|
|
|
|
2014-04-01 21:49:04 +00:00
|
|
|
}
|
2014-08-11 22:52:56 +00:00
|
|
|
|
2014-04-01 21:49:04 +00:00
|
|
|
#endif
|