[AArch64, ARM] Enable GlobalMerge with -O3 rather than -O1.
The pass used to be enabled by default with CodeGenOpt::Less (-O1).
This is too aggressive, considering the pass indiscriminately merges
all globals together.
Currently, performance doesn't always improve, and, on code that uses
few globals (e.g., the odd file- or function- static), more often than
not is degraded by the optimization. Lengthy discussion can be found
on llvmdev (AArch64-focused; ARM has similar problems):
http://lists.cs.uiuc.edu/pipermail/llvmdev/2015-February/082800.html
Also, it makes tooling and debuggers less useful when dealing with
globals and data sections.
GlobalMerge needs to better identify those cases that benefit, and this
will be done separately. In the meantime, move the pass to run with
-O3 rather than -O1, on both ARM and AArch64.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@233024 91177308-0d34-0410-b5e6-96231b3b80d8
2015-03-23 21:17:36 +00:00
|
|
|
; RUN: llc %s -mtriple=aarch64-none-linux-gnu -O3 -enable-global-merge -global-merge-on-external -o - | FileCheck %s
|
|
|
|
|
; RUN: llc %s -mtriple=aarch64-linux-gnuabi -O3 -enable-global-merge -global-merge-on-external -o - | FileCheck %s
|
|
|
|
|
; RUN: llc %s -mtriple=aarch64-apple-ios -O3 -enable-global-merge -global-merge-on-external -o - | FileCheck %s --check-prefix=CHECK-APPLE-IOS
|
2014-06-13 22:57:59 +00:00
|
|
|
|
|
|
|
|
@x = global [1000 x i32] zeroinitializer, align 1
|
|
|
|
|
@y = global [1000 x i32] zeroinitializer, align 1
|
|
|
|
|
@z = internal global i32 1, align 4
|
|
|
|
|
|
|
|
|
|
define void @f1(i32 %a1, i32 %a2, i32 %a3) {
|
|
|
|
|
;CHECK-APPLE-IOS: adrp x8, __MergedGlobals_x@PAGE
|
|
|
|
|
;CHECK-APPLE-IOS-NOT: adrp
|
|
|
|
|
;CHECK-APPLE-IOS: add x8, x8, __MergedGlobals_x@PAGEOFF
|
|
|
|
|
;CHECK-APPLE-IOS: adrp x9, __MergedGlobals_y@PAGE
|
|
|
|
|
;CHECK-APPLE-IOS: add x9, x9, __MergedGlobals_y@PAGEOFF
|
[opaque pointer type] Add textual IR support for explicit type parameter to getelementptr instruction
One of several parallel first steps to remove the target type of pointers,
replacing them with a single opaque pointer type.
This adds an explicit type parameter to the gep instruction so that when the
first parameter becomes an opaque pointer type, the type to gep through is
still available to the instructions.
* This doesn't modify gep operators, only instructions (operators will be
handled separately)
* Textual IR changes only. Bitcode (including upgrade) and changing the
in-memory representation will be in separate changes.
* geps of vectors are transformed as:
getelementptr <4 x float*> %x, ...
->getelementptr float, <4 x float*> %x, ...
Then, once the opaque pointer type is introduced, this will ultimately look
like:
getelementptr float, <4 x ptr> %x
with the unambiguous interpretation that it is a vector of pointers to float.
* address spaces remain on the pointer, not the type:
getelementptr float addrspace(1)* %x
->getelementptr float, float addrspace(1)* %x
Then, eventually:
getelementptr float, ptr addrspace(1) %x
Importantly, the massive amount of test case churn has been automated by
same crappy python code. I had to manually update a few test cases that
wouldn't fit the script's model (r228970,r229196,r229197,r229198). The
python script just massages stdin and writes the result to stdout, I
then wrapped that in a shell script to handle replacing files, then
using the usual find+xargs to migrate all the files.
update.py:
import fileinput
import sys
import re
ibrep = re.compile(r"(^.*?[^%\w]getelementptr inbounds )(((?:<\d* x )?)(.*?)(| addrspace\(\d\)) *\*(|>)(?:$| *(?:%|@|null|undef|blockaddress|getelementptr|addrspacecast|bitcast|inttoptr|\[\[[a-zA-Z]|\{\{).*$))")
normrep = re.compile( r"(^.*?[^%\w]getelementptr )(((?:<\d* x )?)(.*?)(| addrspace\(\d\)) *\*(|>)(?:$| *(?:%|@|null|undef|blockaddress|getelementptr|addrspacecast|bitcast|inttoptr|\[\[[a-zA-Z]|\{\{).*$))")
def conv(match, line):
if not match:
return line
line = match.groups()[0]
if len(match.groups()[5]) == 0:
line += match.groups()[2]
line += match.groups()[3]
line += ", "
line += match.groups()[1]
line += "\n"
return line
for line in sys.stdin:
if line.find("getelementptr ") == line.find("getelementptr inbounds"):
if line.find("getelementptr inbounds") != line.find("getelementptr inbounds ("):
line = conv(re.match(ibrep, line), line)
elif line.find("getelementptr ") != line.find("getelementptr ("):
line = conv(re.match(normrep, line), line)
sys.stdout.write(line)
apply.sh:
for name in "$@"
do
python3 `dirname "$0"`/update.py < "$name" > "$name.tmp" && mv "$name.tmp" "$name"
rm -f "$name.tmp"
done
The actual commands:
From llvm/src:
find test/ -name *.ll | xargs ./apply.sh
From llvm/src/tools/clang:
find test/ -name *.mm -o -name *.m -o -name *.cpp -o -name *.c | xargs -I '{}' ../../apply.sh "{}"
From llvm/src/tools/polly:
find test/ -name *.ll | xargs ./apply.sh
After that, check-all (with llvm, clang, clang-tools-extra, lld,
compiler-rt, and polly all checked out).
The extra 'rm' in the apply.sh script is due to a few files in clang's test
suite using interesting unicode stuff that my python script was throwing
exceptions on. None of those files needed to be migrated, so it seemed
sufficient to ignore those cases.
Reviewers: rafael, dexonsmith, grosser
Differential Revision: http://reviews.llvm.org/D7636
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@230786 91177308-0d34-0410-b5e6-96231b3b80d8
2015-02-27 19:29:02 +00:00
|
|
|
%x3 = getelementptr inbounds [1000 x i32], [1000 x i32]* @x, i32 0, i64 3
|
|
|
|
|
%y3 = getelementptr inbounds [1000 x i32], [1000 x i32]* @y, i32 0, i64 3
|
2014-06-13 22:57:59 +00:00
|
|
|
store i32 %a1, i32* %x3, align 4
|
|
|
|
|
store i32 %a2, i32* %y3, align 4
|
|
|
|
|
store i32 %a3, i32* @z, align 4
|
|
|
|
|
ret void
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
;CHECK: .type _MergedGlobals_x,@object // @_MergedGlobals_x
|
|
|
|
|
;CHECK: .globl _MergedGlobals_x
|
|
|
|
|
;CHECK: .align 4
|
|
|
|
|
;CHECK: _MergedGlobals_x:
|
|
|
|
|
;CHECK: .size _MergedGlobals_x, 4004
|
|
|
|
|
|
|
|
|
|
;CHECK: .type _MergedGlobals_y,@object // @_MergedGlobals_y
|
|
|
|
|
;CHECK: .globl _MergedGlobals_y
|
|
|
|
|
;CHECK: _MergedGlobals_y:
|
|
|
|
|
;CHECK: .size _MergedGlobals_y, 4000
|
|
|
|
|
|
|
|
|
|
;CHECK-APPLE-IOS: .globl __MergedGlobals_x ; @_MergedGlobals_x
|
|
|
|
|
;CHECK-APPLE-IOS: .align 4
|
|
|
|
|
;CHECK-APPLE-IOS: __MergedGlobals_x:
|
|
|
|
|
;CHECK-APPLE-IOS: .long 1
|
|
|
|
|
;CHECK-APPLE-IOS: .space 4000
|
|
|
|
|
|
|
|
|
|
;CHECK-APPLE-IOS: .globl __MergedGlobals_y ; @_MergedGlobals_y
|
|
|
|
|
;CHECK-APPLE-IOS: .zerofill __DATA,__common,__MergedGlobals_y,4000,4
|
|
|
|
|
|
|
|
|
|
;CHECK: .globl x
|
|
|
|
|
;CHECK: x = _MergedGlobals_x+4
|
|
|
|
|
;CHECK: .globl y
|
|
|
|
|
;CHECK: y = _MergedGlobals_y
|
|
|
|
|
|
|
|
|
|
;CHECK-APPLE-IOS:.globl _x
|
|
|
|
|
;CHECK-APPLE-IOS: _x = __MergedGlobals_x+4
|
|
|
|
|
;CHECK-APPLE-IOS:.globl _y
|
|
|
|
|
;CHECK-APPLE-IOS: _y = __MergedGlobals_y
|
