2014-03-13 20:31:19 +00:00
|
|
|
; RUN: llc < %s -march=x86-64 -mtriple=x86_64-linux | FileCheck %s
|
2014-03-13 18:47:12 +00:00
|
|
|
|
|
|
|
|
; The Peephole optimizer should fold the load into the cmp even with debug info.
|
|
|
|
|
; CHECK-LABEL: _ZN3Foo3batEv
|
|
|
|
|
; CHECK-NOT: movq pfoo
|
|
|
|
|
; CHECK: cmpq {{%[a-z]+}}, pfoo(%rip)
|
|
|
|
|
;
|
|
|
|
|
; CHECK-LABEL: _Z3bazv
|
|
|
|
|
; CHECK-NOT: movq wibble2
|
|
|
|
|
; CHECK: cmpq {{%[a-z]+}}, wibble2(%rip)
|
|
|
|
|
|
|
|
|
|
; Regenerate test with this command:
|
|
|
|
|
; clang -emit-llvm -S -O2 -g
|
|
|
|
|
; from this source:
|
|
|
|
|
; struct Foo {
|
|
|
|
|
; bool bat();
|
|
|
|
|
; bool operator==(Foo &arg) { return (this == &arg); }
|
|
|
|
|
; };
|
|
|
|
|
; Foo *pfoo;
|
|
|
|
|
; bool Foo::bat() { return (*this == *pfoo); }
|
|
|
|
|
;
|
|
|
|
|
; struct Wibble {
|
|
|
|
|
; int x;
|
|
|
|
|
; } *wibble1, *wibble2;
|
|
|
|
|
; struct Flibble {
|
|
|
|
|
; void bar(Wibble *c) {
|
|
|
|
|
; if (c < wibble2)
|
|
|
|
|
; wibble2 = 0;
|
|
|
|
|
; c->x = 0;
|
|
|
|
|
; }
|
|
|
|
|
; } flibble;
|
|
|
|
|
; void baz() { flibble.bar(wibble1); }
|
|
|
|
|
|
|
|
|
|
%struct.Foo = type { i8 }
|
|
|
|
|
%struct.Wibble = type { i32 }
|
|
|
|
|
%struct.Flibble = type { i8 }
|
|
|
|
|
|
|
|
|
|
@pfoo = global %struct.Foo* null, align 8
|
|
|
|
|
@wibble1 = global %struct.Wibble* null, align 8
|
|
|
|
|
@wibble2 = global %struct.Wibble* null, align 8
|
|
|
|
|
@flibble = global %struct.Flibble zeroinitializer, align 1
|
|
|
|
|
|
|
|
|
|
; Function Attrs: nounwind readonly uwtable
|
|
|
|
|
define zeroext i1 @_ZN3Foo3batEv(%struct.Foo* %this) #0 align 2 {
|
|
|
|
|
entry:
|
|
|
|
|
%0 = load %struct.Foo** @pfoo, align 8
|
2014-10-03 20:01:09 +00:00
|
|
|
tail call void @llvm.dbg.value(metadata !{%struct.Foo* %0}, i64 0, metadata !62, metadata !{metadata !"0x102"})
|
2014-03-13 18:47:12 +00:00
|
|
|
%cmp.i = icmp eq %struct.Foo* %0, %this
|
|
|
|
|
ret i1 %cmp.i
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
; Function Attrs: nounwind uwtable
|
|
|
|
|
define void @_Z3bazv() #1 {
|
|
|
|
|
entry:
|
|
|
|
|
%0 = load %struct.Wibble** @wibble1, align 8
|
2014-10-03 20:01:09 +00:00
|
|
|
tail call void @llvm.dbg.value(metadata !64, i64 0, metadata !65, metadata !{metadata !"0x102"})
|
2014-03-13 18:47:12 +00:00
|
|
|
%1 = load %struct.Wibble** @wibble2, align 8
|
|
|
|
|
%cmp.i = icmp ugt %struct.Wibble* %1, %0
|
|
|
|
|
br i1 %cmp.i, label %if.then.i, label %_ZN7Flibble3barEP6Wibble.exit
|
|
|
|
|
|
|
|
|
|
if.then.i: ; preds = %entry
|
|
|
|
|
store %struct.Wibble* null, %struct.Wibble** @wibble2, align 8
|
|
|
|
|
br label %_ZN7Flibble3barEP6Wibble.exit
|
|
|
|
|
|
|
|
|
|
_ZN7Flibble3barEP6Wibble.exit: ; preds = %entry, %if.then.i
|
|
|
|
|
%x.i = getelementptr inbounds %struct.Wibble* %0, i64 0, i32 0
|
|
|
|
|
store i32 0, i32* %x.i, align 4
|
|
|
|
|
ret void
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
; Function Attrs: nounwind readnone
|
Move the complex address expression out of DIVariable and into an extra
argument of the llvm.dbg.declare/llvm.dbg.value intrinsics.
Previously, DIVariable was a variable-length field that has an optional
reference to a Metadata array consisting of a variable number of
complex address expressions. In the case of OpPiece expressions this is
wasting a lot of storage in IR, because when an aggregate type is, e.g.,
SROA'd into all of its n individual members, the IR will contain n copies
of the DIVariable, all alike, only differing in the complex address
reference at the end.
By making the complex address into an extra argument of the
dbg.value/dbg.declare intrinsics, all of the pieces can reference the
same variable and the complex address expressions can be uniqued across
the CU, too.
Down the road, this will allow us to move other flags, such as
"indirection" out of the DIVariable, too.
The new intrinsics look like this:
declare void @llvm.dbg.declare(metadata %storage, metadata %var, metadata %expr)
declare void @llvm.dbg.value(metadata %storage, i64 %offset, metadata %var, metadata %expr)
This patch adds a new LLVM-local tag to DIExpressions, so we can detect
and pretty-print DIExpression metadata nodes.
What this patch doesn't do:
This patch does not touch the "Indirect" field in DIVariable; but moving
that into the expression would be a natural next step.
http://reviews.llvm.org/D4919
rdar://problem/17994491
Thanks to dblaikie and dexonsmith for reviewing this patch!
Note: I accidentally committed a bogus older version of this patch previously.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@218787 91177308-0d34-0410-b5e6-96231b3b80d8
2014-10-01 18:55:02 +00:00
|
|
|
declare void @llvm.dbg.value(metadata, i64, metadata, metadata) #2
|
2014-03-13 18:47:12 +00:00
|
|
|
|
|
|
|
|
attributes #0 = { nounwind readonly uwtable "less-precise-fpmad"="false" "no-frame-pointer-elim"="false" "no-frame-pointer-elim-non-leaf"="false" "no-infs-fp-math"="false" "no-nans-fp-math"="false" "unsafe-fp-math"="false" "use-soft-float"="false" }
|
|
|
|
|
attributes #1 = { nounwind uwtable "less-precise-fpmad"="false" "no-frame-pointer-elim"="false" "no-frame-pointer-elim-non-leaf"="false" "no-infs-fp-math"="false" "no-nans-fp-math"="false" "unsafe-fp-math"="false" "use-soft-float"="false" }
|
|
|
|
|
attributes #2 = { nounwind readnone }
|
|
|
|
|
|
|
|
|
|
|
2014-10-03 20:01:09 +00:00
|
|
|
!17 = metadata !{metadata !"0x10\00\000\000\000\000\000", null, null, null} ; [ DW_TAG_reference_type ] [line 0, size 0, align 0, offset 0] [from Foo]
|
|
|
|
|
!45 = metadata !{metadata !"0xf\00\000\0064\0064\000\000", null, null, null} ; [ DW_TAG_pointer_type ] [line 0, size 64, align 64, offset 0] [from Flibble]
|
|
|
|
|
!62 = metadata !{metadata !"0x101\00arg\0033554436\000", null, null, metadata !17} ; [ DW_TAG_arg_variable ] [arg] [line 4]
|
2014-03-13 18:47:12 +00:00
|
|
|
!64 = metadata !{%struct.Flibble* undef}
|
2014-10-03 20:01:09 +00:00
|
|
|
!65 = metadata !{metadata !"0x101\00this\0016777229\001088", null, null, metadata !45} ; [ DW_TAG_arg_variable ] [this] [line 13]
|
