6502/llvm-6502
1
0
Fork 0
mirror of https://github.com/c64scene-ar/llvm-6502.git synced 2025-07-28 03:25:23 +00:00
Code Issues Projects Releases Wiki Activity

Unit test r218187, changing RTDyldMemoryManager::getSymbolAddress's behavior favor mangled lookup over unmangled lookup.

Browse Source 
The contract of this function seems problematic (fallback in either
direction seems like it could produce bugs in one client or another),
but here's some tests for its current behavior, at least. See the
commit/review thread of r218187 for more discussion.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@218626 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
David Blaikie
2014-09-29 21:25:13 +00:00
parent 7b2aaade87
commit 03b4667e14
3 changed files with 36 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
include/llvm/ExecutionEngine/RTDyldMemoryManager.h
View File

@@ -24,6 +24,8 @@ namespace llvm {
class ExecutionEngine;
class ObjectImage;
uint64_t getSymbolAddress(const std::string &Name);
// RuntimeDyld clients often want to handle the memory management of
// what gets placed where. For JIT clients, this is the subset of
// JITMemoryManager required for dynamic loading of binaries.
@@ -78,7 +80,9 @@ public:
/// This method returns the address of the specified function or variable.
/// It is used to resolve symbols during module linking.
virtual uint64_t getSymbolAddress(const std::string &Name);
virtual uint64_t getSymbolAddress(const std::string &Name) {
return llvm::getSymbolAddress(Name);
}
/// This method returns the address of the specified function. As such it is
/// only useful for resolving library symbols, not code generated symbols.