6502/llvm-6502
1
0
Fork 0
mirror of https://github.com/c64scene-ar/llvm-6502.git synced 2025-06-15 21:24:00 +00:00
Code Issues Projects Releases Wiki Activity

Unit test r218187, changing RTDyldMemoryManager::getSymbolAddress's behavior favor mangled lookup over unmangled lookup.

Browse Source 
The contract of this function seems problematic (fallback in either
direction seems like it could produce bugs in one client or another),
but here's some tests for its current behavior, at least. See the
commit/review thread of r218187 for more discussion.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@218626 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
David Blaikie
2014-09-29 21:25:13 +00:00
parent 7b2aaade87
commit 03b4667e14
3 changed files with 36 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
unittests/ExecutionEngine/ExecutionEngineTest.cpp
View File

@ -8,10 +8,12 @@
//===----------------------------------------------------------------------===//
#include "llvm/ExecutionEngine/Interpreter.h"
#include "llvm/ExecutionEngine/RTDyldMemoryManager.h"
#include "llvm/IR/DerivedTypes.h"
#include "llvm/IR/GlobalVariable.h"
#include "llvm/IR/LLVMContext.h"
#include "llvm/IR/Module.h"
#include "llvm/Support/DynamicLibrary.h"
#include "llvm/Support/ManagedStatic.h"
#include "gtest/gtest.h"
@ -132,4 +134,32 @@ TEST_F(ExecutionEngineTest, DestructionRemovesGlobalMapping) {
EXPECT_EQ(nullptr, Engine->getGlobalValueAtAddress(&Mem1));
}
TEST_F(ExecutionEngineTest, LookupWithMangledName) {
int x;
llvm::sys::DynamicLibrary::AddSymbol("x", &x);
// Demonstrate that getSymbolAddress accepts mangled names and always strips
// the leading underscore.
EXPECT_EQ(reinterpret_cast<uint64_t>(&x), getSymbolAddress("_x"));
}
TEST_F(ExecutionEngineTest, LookupWithMangledAndDemangledSymbol) {
int x;
int _x;
llvm::sys::DynamicLibrary::AddSymbol("x", &x);
llvm::sys::DynamicLibrary::AddSymbol("_x", &_x);
// Lookup the demangled name first, even if there's a demangled symbol that
// matches the input already.
EXPECT_EQ(reinterpret_cast<uint64_t>(&x), getSymbolAddress("_x"));
}
TEST_F(ExecutionEngineTest, LookupwithDemangledName) {
int _x;
llvm::sys::DynamicLibrary::AddSymbol("_x", &_x);
// But do fallback to looking up a demangled name if there's no ambiguity
EXPECT_EQ(reinterpret_cast<uint64_t>(&_x), getSymbolAddress("_x"));
}
}