Various improvements suggested by Duncan

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@48325 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Chris Lattner 2008-03-13 04:33:03 +00:00
parent 7520fcd7a5
commit 041221c097
4 changed files with 11 additions and 9 deletions

View File

@ -144,10 +144,12 @@ public:
SubclassData = (SubclassData & 1) | (CC << 1); SubclassData = (SubclassData & 1) | (CC << 1);
} }
/// getParamAttrs - Return the parameter attributes for this function. /// getParamAttrs - Return the parameter attributes for this Function.
///
const PAListPtr &getParamAttrs() const { return ParamAttrs; } const PAListPtr &getParamAttrs() const { return ParamAttrs; }
/// setParamAttrs - Set the parameter attributes for this Function. /// setParamAttrs - Set the parameter attributes for this Function.
///
void setParamAttrs(const PAListPtr &attrs) { ParamAttrs = attrs; } void setParamAttrs(const PAListPtr &attrs) { ParamAttrs = attrs; }
/// hasCollector/getCollector/setCollector/clearCollector - The name of the /// hasCollector/getCollector/setCollector/clearCollector - The name of the

View File

@ -926,11 +926,11 @@ public:
SubclassData = (SubclassData & 1) | (CC << 1); SubclassData = (SubclassData & 1) | (CC << 1);
} }
/// getParamAttrs - Return the PAListPtr for the parameter attributes of this /// getParamAttrs - Return the parameter attributes for this call.
/// call. ///
const PAListPtr &getParamAttrs() const { return ParamAttrs; } const PAListPtr &getParamAttrs() const { return ParamAttrs; }
/// setParamAttrs - Sets the parameter attributes for this CallInst. /// setParamAttrs - Sets the parameter attributes for this call.
void setParamAttrs(const PAListPtr &Attrs) { ParamAttrs = Attrs; } void setParamAttrs(const PAListPtr &Attrs) { ParamAttrs = Attrs; }
/// @brief Determine whether the call or the callee has the given attribute. /// @brief Determine whether the call or the callee has the given attribute.
@ -1740,11 +1740,11 @@ public:
SubclassData = CC; SubclassData = CC;
} }
/// getParamAttrs - Return the parameter attribute list for this invoke. /// getParamAttrs - Return the parameter attributes for this invoke.
/// ///
const PAListPtr &getParamAttrs() const { return ParamAttrs; } const PAListPtr &getParamAttrs() const { return ParamAttrs; }
/// setParamAttrs - Set the parameter attribute list for this invoke. /// setParamAttrs - Set the parameter attributes for this invoke.
/// ///
void setParamAttrs(const PAListPtr &Attrs) { ParamAttrs = Attrs; } void setParamAttrs(const PAListPtr &Attrs) { ParamAttrs = Attrs; }

View File

@ -120,7 +120,7 @@ public:
static PAListPtr get(const ParamAttrsWithIndex *Attr, unsigned NumAttrs); static PAListPtr get(const ParamAttrsWithIndex *Attr, unsigned NumAttrs);
/// get - Return a ParamAttr list with the parameters specified by the /// get - Return a ParamAttr list with the parameters specified by the
/// consequtive random access iterator range. /// consecutive random access iterator range.
template <typename Iter> template <typename Iter>
static PAListPtr get(const Iter &I, const Iter &E) { static PAListPtr get(const Iter &I, const Iter &E) {
if (I == E) return PAListPtr(); // Empty list. if (I == E) return PAListPtr(); // Empty list.
@ -161,7 +161,7 @@ public:
/// least one parameter or for the return value. /// least one parameter or for the return value.
bool hasAttrSomewhere(ParameterAttributes Attr) const; bool hasAttrSomewhere(ParameterAttributes Attr) const;
/// operator< - Provide an ordering for parameter attribute lists. /// operator==/!= - Provide equality predicates.
bool operator==(const PAListPtr &RHS) const { return PAList == RHS.PAList; } bool operator==(const PAListPtr &RHS) const { return PAList == RHS.PAList; }
bool operator!=(const PAListPtr &RHS) const { return PAList != RHS.PAList; } bool operator!=(const PAListPtr &RHS) const { return PAList != RHS.PAList; }

View File

@ -77,7 +77,7 @@ namespace llvm {
class ParamAttributeListImpl : public FoldingSetNode { class ParamAttributeListImpl : public FoldingSetNode {
unsigned RefCount; unsigned RefCount;
// ParamAttrsList is uniqued, these should not be publicly available // ParamAttrsList is uniqued, these should not be publicly available.
void operator=(const ParamAttributeListImpl &); // Do not implement void operator=(const ParamAttributeListImpl &); // Do not implement
ParamAttributeListImpl(const ParamAttributeListImpl &); // Do not implement ParamAttributeListImpl(const ParamAttributeListImpl &); // Do not implement
~ParamAttributeListImpl(); // Private implementation ~ParamAttributeListImpl(); // Private implementation