Fix PR6921: globals were not getting correctly rounded up to their

preferred alignment unless they were common or some other special
case.


git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@102300 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Chris Lattner 2010-04-25 05:30:43 +00:00
parent 73382423f2
commit 044698b39a
3 changed files with 22 additions and 5 deletions

View File

@ -285,7 +285,7 @@ void AsmPrinter::EmitGlobalVariable(const GlobalVariable *GV) {
OutStreamer.SwitchSection(TheSection);
EmitLinkage(GV->getLinkage(), GVSym);
EmitAlignment(AlignLog, GV);
EmitAlignment(AlignLog, GV, AlignLog);
if (isVerbose()) {
WriteAsOperand(OutStreamer.GetCommentOS(), GV,
@ -987,7 +987,7 @@ bool AsmPrinter::EmitSpecialLLVMGlobal(const GlobalVariable *GV) {
unsigned Align = Log2_32(TD->getPointerPrefAlignment());
if (GV->getName() == "llvm.global_ctors") {
OutStreamer.SwitchSection(getObjFileLowering().getStaticCtorSection());
EmitAlignment(Align, 0);
EmitAlignment(Align);
EmitXXStructorList(GV->getInitializer());
if (TM.getRelocationModel() == Reloc::Static &&
@ -1001,7 +1001,7 @@ bool AsmPrinter::EmitSpecialLLVMGlobal(const GlobalVariable *GV) {
if (GV->getName() == "llvm.global_dtors") {
OutStreamer.SwitchSection(getObjFileLowering().getStaticDtorSection());
EmitAlignment(Align, 0);
EmitAlignment(Align);
EmitXXStructorList(GV->getInitializer());
if (TM.getRelocationModel() == Reloc::Static &&

View File

@ -0,0 +1,16 @@
; RUN: llc %s -o - -mtriple=x86_64-linux-gnu | FileCheck %s
; This can get rounded up to the preferred alignment (16).
; PR6921
@GlobalA = global { [384 x i8] } zeroinitializer, align 8
; CHECK: .bss
; CHECK: .globl GlobalA
; CHECK: .align 16
; CHECK: GlobalA:
; CHECK: .zero 384
; Common variables should also get rounded up to the preferred alignment (16).
@GlobalB = common global { [384 x i8] } zeroinitializer, align 8
; CHECK: .comm GlobalB,384,16

View File

@ -28,8 +28,9 @@ return:
declare void @llvm.memcpy.i64(i8* nocapture, i8* nocapture, i64, i32) nounwind
; CORE2: .align 3
; CORE2: .section
; CORE2: .align 4
; CORE2-NEXT: _.str1:
; CORE2-NEXT: .asciz "DHRYSTONE PROGRAM, SOME STRING"
; CORE2: .align 3
; CORE2: .align 4
; CORE2-NEXT: _.str3: