From 048c00db1cd05bbbd616e0eff71756eebd45f6b4 Mon Sep 17 00:00:00 2001 From: Chris Lattner Date: Fri, 1 Aug 2003 04:38:18 +0000 Subject: [PATCH] Simplify code to match new interfaces git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@7464 91177308-0d34-0410-b5e6-96231b3b80d8 --- support/tools/TableGen/CodeEmitterGen.cpp | 12 ++++-------- support/tools/TableGen/CodeEmitterGen.h | 4 ++-- utils/TableGen/CodeEmitterGen.cpp | 12 ++++-------- utils/TableGen/CodeEmitterGen.h | 4 ++-- 4 files changed, 12 insertions(+), 20 deletions(-) diff --git a/support/tools/TableGen/CodeEmitterGen.cpp b/support/tools/TableGen/CodeEmitterGen.cpp index e24211e24d1..0619967f770 100644 --- a/support/tools/TableGen/CodeEmitterGen.cpp +++ b/support/tools/TableGen/CodeEmitterGen.cpp @@ -8,9 +8,8 @@ #include "Record.h" #include "Support/Statistic.h" -bool CodeEmitterGen::run(std::ostream &o) { - std::vector Insts; - if (Records.getAllDerivedDefinitions("Instruction", Insts)) return true; +void CodeEmitterGen::run(std::ostream &o) { + std::vector Insts = Records.getAllDerivedDefinitions("Instruction"); std::string Namespace = "V9::"; std::string ClassName = "SparcV9CodeEmitter::"; @@ -28,10 +27,8 @@ bool CodeEmitterGen::run(std::ostream &o) { << " DEBUG(std::cerr << \"Emitting " << R->getName() << "\\n\");\n"; const RecordVal *InstVal = R->getValue("Inst"); - if (!InstVal) { - std::cerr << "No 'Inst' record found in target description file!\n"; - return true; - } + if (!InstVal) + throw std::string("No 'Inst' record found in target description file!"); Init *InitVal = InstVal->getValue(); assert(dynamic_cast(InitVal) && @@ -226,5 +223,4 @@ bool CodeEmitterGen::run(std::ostream &o) { << " }\n" << " return Value;\n" << "}\n"; - return false; } diff --git a/support/tools/TableGen/CodeEmitterGen.h b/support/tools/TableGen/CodeEmitterGen.h index 16420340243..7ae3ef8d92c 100644 --- a/support/tools/TableGen/CodeEmitterGen.h +++ b/support/tools/TableGen/CodeEmitterGen.h @@ -16,8 +16,8 @@ class CodeEmitterGen { public: CodeEmitterGen(RecordKeeper &R) : Records(R) {} - // run - Output the code emitter, returning true on failure. - bool run(std::ostream &o); + // run - Output the code emitter + void run(std::ostream &o); private: void emitMachineOpEmitter(std::ostream &o, const std::string &Namespace); void emitGetValueBit(std::ostream &o, const std::string &Namespace); diff --git a/utils/TableGen/CodeEmitterGen.cpp b/utils/TableGen/CodeEmitterGen.cpp index e24211e24d1..0619967f770 100644 --- a/utils/TableGen/CodeEmitterGen.cpp +++ b/utils/TableGen/CodeEmitterGen.cpp @@ -8,9 +8,8 @@ #include "Record.h" #include "Support/Statistic.h" -bool CodeEmitterGen::run(std::ostream &o) { - std::vector Insts; - if (Records.getAllDerivedDefinitions("Instruction", Insts)) return true; +void CodeEmitterGen::run(std::ostream &o) { + std::vector Insts = Records.getAllDerivedDefinitions("Instruction"); std::string Namespace = "V9::"; std::string ClassName = "SparcV9CodeEmitter::"; @@ -28,10 +27,8 @@ bool CodeEmitterGen::run(std::ostream &o) { << " DEBUG(std::cerr << \"Emitting " << R->getName() << "\\n\");\n"; const RecordVal *InstVal = R->getValue("Inst"); - if (!InstVal) { - std::cerr << "No 'Inst' record found in target description file!\n"; - return true; - } + if (!InstVal) + throw std::string("No 'Inst' record found in target description file!"); Init *InitVal = InstVal->getValue(); assert(dynamic_cast(InitVal) && @@ -226,5 +223,4 @@ bool CodeEmitterGen::run(std::ostream &o) { << " }\n" << " return Value;\n" << "}\n"; - return false; } diff --git a/utils/TableGen/CodeEmitterGen.h b/utils/TableGen/CodeEmitterGen.h index 16420340243..7ae3ef8d92c 100644 --- a/utils/TableGen/CodeEmitterGen.h +++ b/utils/TableGen/CodeEmitterGen.h @@ -16,8 +16,8 @@ class CodeEmitterGen { public: CodeEmitterGen(RecordKeeper &R) : Records(R) {} - // run - Output the code emitter, returning true on failure. - bool run(std::ostream &o); + // run - Output the code emitter + void run(std::ostream &o); private: void emitMachineOpEmitter(std::ostream &o, const std::string &Namespace); void emitGetValueBit(std::ostream &o, const std::string &Namespace);