Simplify some of the PHI node interfaces

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@5700 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Chris Lattner 2003-03-05 21:15:12 +00:00
parent e2ca540e7c
commit 05ddff9b98
2 changed files with 18 additions and 17 deletions

View File

@ -61,7 +61,12 @@ public:
}
/// addIncoming - Add an incoming value to the end of the PHI list
void addIncoming(Value *D, BasicBlock *BB);
void addIncoming(Value *D, BasicBlock *BB) {
assert(getType() == D->getType() &&
"All operands to PHI node must be the same type as the PHI node!");
Operands.push_back(Use(D, this));
Operands.push_back(Use((Value*)BB, this));
}
/// removeIncomingValue - Remove an incoming value. This is useful if a
/// predecessor basic block is deleted. The value removed is returned.
@ -71,8 +76,13 @@ public:
/// dummy values. The only time there should be zero incoming values to a PHI
/// node is when the block is dead, so this strategy is sound.
///
Value *removeIncomingValue(const BasicBlock *BB,
bool DeletePHIIfEmpty = true);
Value *removeIncomingValue(unsigned Idx, bool DeletePHIIfEmpty = true);
Value *removeIncomingValue(const BasicBlock *BB, bool DeletePHIIfEmpty =true){
int Idx = getBasicBlockIndex(BB);
assert(Idx >= 0 && "Invalid basic block argument to remove!");
return removeIncomingValue(Idx, DeletePHIIfEmpty);
}
/// getBasicBlockIndex - Return the first index of the specified basic
/// block in the value list for this PHI. Returns -1 if no instance.

View File

@ -33,22 +33,13 @@ PHINode::PHINode(const PHINode &PN)
}
}
void PHINode::addIncoming(Value *D, BasicBlock *BB) {
assert(getType() == D->getType() &&
"All operands to PHI node must be the same type as the PHI node!");
Operands.push_back(Use(D, this));
Operands.push_back(Use(BB, this));
}
// removeIncomingValue - Remove an incoming value. This is useful if a
// predecessor basic block is deleted.
Value *PHINode::removeIncomingValue(const BasicBlock *BB,
bool DeletePHIIfEmpty) {
op_iterator Idx = find(Operands.begin(), Operands.end(), (const Value*)BB);
assert(Idx != Operands.end() && "BB not in PHI node!");
--Idx; // Back up to value prior to Basic block
Value *Removed = *Idx;
Operands.erase(Idx, Idx+2); // Erase Value and BasicBlock
Value *PHINode::removeIncomingValue(unsigned Idx, bool DeletePHIIfEmpty) {
assert(Idx*2 < Operands.size() && "BB not in PHI node!");
Value *Removed = Operands[Idx*2];
Operands.erase(Operands.begin()+Idx*2, // Erase Value and BasicBlock
Operands.begin()+Idx*2+2);
// If the PHI node is dead, because it has zero entries, nuke it now.
if (getNumOperands() == 0 && DeletePHIIfEmpty) {