6502/llvm-6502
1
0
Fork 0
mirror of https://github.com/c64scene-ar/llvm-6502.git synced 2025-07-29 10:25:12 +00:00
Code Issues Projects Releases Wiki Activity

include/llvm/Object/ELF.h: do debug checks only when NDEBUG

Browse Source 
validateSymbol() is called all over the place, and it seems it's a debug check.
It significantly speedups llvm-symbolizer used in tsan/asan/msan. validateSymbol() is the second hot function and accounts for 15% of runtime.


git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@175192 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Dmitry Vyukov
2013-02-14 18:41:42 +00:00
parent 6cc4b8d1eb
commit 06121de923
1 changed files with 2 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
include/llvm/Object/ELF.h
View File

@@ -867,6 +867,7 @@ void ELFObjectFile<ELFT>::LoadVersionMap() const {
template<class ELFT> template<class ELFT>
void ELFObjectFile<ELFT>::validateSymbol(DataRefImpl Symb) const { void ELFObjectFile<ELFT>::validateSymbol(DataRefImpl Symb) const {
#ifndef NDEBUG
const Elf_Sym *symb = getSymbol(Symb); const Elf_Sym *symb = getSymbol(Symb);
const Elf_Shdr *SymbolTableSection = SymbolTableSections[Symb.d.b]; const Elf_Shdr *SymbolTableSection = SymbolTableSections[Symb.d.b];
// FIXME: We really need to do proper error handling in the case of an invalid // FIXME: We really need to do proper error handling in the case of an invalid
@@ -881,6 +882,7 @@ void ELFObjectFile<ELFT>::validateSymbol(DataRefImpl Symb) const {
+ SymbolTableSection->sh_size))) + SymbolTableSection->sh_size)))
// FIXME: Proper error handling. // FIXME: Proper error handling.
report_fatal_error("Symb must point to a valid symbol!"); report_fatal_error("Symb must point to a valid symbol!");
#endif
} }
template<class ELFT> template<class ELFT>