From 06887c9a2ad0d30c3cdfeff4d5e268a634c9d1a6 Mon Sep 17 00:00:00 2001 From: Chris Lattner Date: Sun, 29 Feb 2004 22:24:41 +0000 Subject: [PATCH] Fix bug: test/Regression/Transforms/LowerInvoke/2004-02-29-PHICrash.llx ... which tickled the lowerinvoke pass because it used the BCE routines. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@12012 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Transforms/Utils/BreakCriticalEdges.cpp | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/lib/Transforms/Utils/BreakCriticalEdges.cpp b/lib/Transforms/Utils/BreakCriticalEdges.cpp index 178e8ca1957..8e00f9c613e 100644 --- a/lib/Transforms/Utils/BreakCriticalEdges.cpp +++ b/lib/Transforms/Utils/BreakCriticalEdges.cpp @@ -119,8 +119,11 @@ bool llvm::SplitCriticalEdge(TerminatorInst *TI, unsigned SuccNum, Pass *P) { // for (BasicBlock::iterator I = DestBB->begin(); PHINode *PN = dyn_cast(I); ++I) { - // We no longer enter through TIBB, now we come in through NewBB. - PN->replaceUsesOfWith(TIBB, NewBB); + // We no longer enter through TIBB, now we come in through NewBB. Revector + // exactly one entry in the PHI node that used to come from TIBB to come + // from NewBB. + Value *InVal = PN->removeIncomingValue(TIBB, false); + PN->addIncoming(InVal, NewBB); } // If we don't have a pass object, we can't update anything...