6502/llvm-6502
1
0
Fork 0
mirror of https://github.com/c64scene-ar/llvm-6502.git synced 2025-06-29 13:24:25 +00:00
Code Issues Projects Releases Wiki Activity

Document and fix Constant::getVectorElements to return an empty vector

Browse Source 
when presented with a constant expr.

If ConstantExpr::getV[IF]Cmp to work when ConstantFoldCompareInstruction
returns an undef or constant expr.  



git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@53541 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Chris Lattner
2008-07-14 05:10:41 +00:00
parent ac77bfdbd4
commit 071aade5f0
1 changed files with 23 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

35
lib/VMCore/Constants.cpp
View File

@ -157,7 +157,8 @@ ConstantVector *ConstantVector::getAllOnesValue(const VectorType *Ty) {
/// getVectorElements - This method, which is only valid on constant of vector /// getVectorElements - This method, which is only valid on constant of vector
/// type, returns the elements of the vector in the specified smallvector. /// type, returns the elements of the vector in the specified smallvector.
/// This handles breaking down a vector undef into undef elements, etc. /// This handles breaking down a vector undef into undef elements, etc. For
/// constant exprs and other cases we can't handle, we return an empty vector.
void Constant::getVectorElements(SmallVectorImpl<Constant*> &Elts) const { void Constant::getVectorElements(SmallVectorImpl<Constant*> &Elts) const {
assert(isa<VectorType>(getType()) && "Not a vector constant!"); assert(isa<VectorType>(getType()) && "Not a vector constant!");
@ -174,8 +175,12 @@ void Constant::getVectorElements(SmallVectorImpl<Constant*> &Elts) const {
return; return;
} }
assert(isa<UndefValue>(this) && "Unknown vector constant type!"); if (isa<UndefValue>(this)) {
Elts.assign(VT->getNumElements(), UndefValue::get(VT->getElementType())); Elts.assign(VT->getNumElements(), UndefValue::get(VT->getElementType()));
return;
}
// Unknown type, must be constant expr etc.
} }
@ -2206,16 +2211,19 @@ ConstantExpr::getVICmp(unsigned short pred, Constant* LHS, Constant* RHS) {
const Type *EltTy = VTy->getElementType(); const Type *EltTy = VTy->getElementType();
unsigned NumElts = VTy->getNumElements(); unsigned NumElts = VTy->getNumElements();
SmallVector<Constant *, 8> Elts; SmallVector<Constant *, 16> Elts;
for (unsigned i = 0; i != NumElts; ++i) { for (unsigned i = 0; i != NumElts; ++i) {
Constant *FC = ConstantFoldCompareInstruction(pred, LHS->getOperand(i), Constant *FC = ConstantFoldCompareInstruction(pred, LHS->getOperand(i),
RHS->getOperand(i)); RHS->getOperand(i));
if (FC) { if (ConstantInt *FCI = dyn_cast_or_null<ConstantInt>(FC)) {
uint64_t Val = cast<ConstantInt>(FC)->getZExtValue(); if (FCI->getZExtValue())
if (Val != 0ULL)
Elts.push_back(ConstantInt::getAllOnesValue(EltTy)); Elts.push_back(ConstantInt::getAllOnesValue(EltTy));
else else
Elts.push_back(ConstantInt::get(EltTy, 0ULL)); Elts.push_back(ConstantInt::get(EltTy, 0ULL));
} else if (FC && isa<UndefValue>(FC)) {
Elts.push_back(UndefValue::get(EltTy));
} else {
break;
} }
} }
if (Elts.size() == NumElts) if (Elts.size() == NumElts)
@ -2243,16 +2251,19 @@ ConstantExpr::getVFCmp(unsigned short pred, Constant* LHS, Constant* RHS) {
const Type *REltTy = IntegerType::get(EltTy->getPrimitiveSizeInBits()); const Type *REltTy = IntegerType::get(EltTy->getPrimitiveSizeInBits());
const Type *ResultTy = VectorType::get(REltTy, NumElts); const Type *ResultTy = VectorType::get(REltTy, NumElts);
SmallVector<Constant *, 8> Elts; SmallVector<Constant *, 16> Elts;
for (unsigned i = 0; i != NumElts; ++i) { for (unsigned i = 0; i != NumElts; ++i) {
Constant *FC = ConstantFoldCompareInstruction(pred, LHS->getOperand(i), Constant *FC = ConstantFoldCompareInstruction(pred, LHS->getOperand(i),
RHS->getOperand(i)); RHS->getOperand(i));
if (FC) { if (ConstantInt *FCI = dyn_cast_or_null<ConstantInt>(FC)) {
uint64_t Val = cast<ConstantInt>(FC)->getZExtValue(); if (FCI->getZExtValue())
if (Val != 0ULL)
Elts.push_back(ConstantInt::getAllOnesValue(REltTy)); Elts.push_back(ConstantInt::getAllOnesValue(REltTy));
else else
Elts.push_back(ConstantInt::get(REltTy, 0ULL)); Elts.push_back(ConstantInt::get(REltTy, 0ULL));
} else if (FC && isa<UndefValue>(FC)) {
Elts.push_back(UndefValue::get(REltTy));
} else {
break;
} }
} }
if (Elts.size() == NumElts) if (Elts.size() == NumElts)