diff --git a/lib/CodeGen/SelectionDAG/DAGCombiner.cpp b/lib/CodeGen/SelectionDAG/DAGCombiner.cpp index e581ed3d948..0bb11fa330b 100644 --- a/lib/CodeGen/SelectionDAG/DAGCombiner.cpp +++ b/lib/CodeGen/SelectionDAG/DAGCombiner.cpp @@ -4122,6 +4122,34 @@ SDOperand DAGCombiner::visitLOAD(SDNode *N) { return SDOperand(); } +/// ReachesChainWithoutSideEffects - Do a little local search to see if Src can +/// reach Dest without any side effects like a store, or call. Non-volatile +/// loads are ok though. +static bool ReachesChainWithoutSideEffects(SDOperand Src, SDOperand Dest, + unsigned Depth = 0) { + if (Src == Dest) return true; + + // Don't search too deeply, we just want to be able to see through + // TokenFactor's etc. + if (Depth == 2) return false; + + // If this is a token factor, all inputs to the TF happen in parallel. If any + // of the operands of the TF reach dest, then we can do the xform. + if (Src.getOpcode() == ISD::TokenFactor) { + for (unsigned i = 0, e = Src.getNumOperands(); i != e; ++i) + if (ReachesChainWithoutSideEffects(Src.getOperand(i), Dest, Depth+1)) + return true; + return false; + } + + // Loads don't have side effects, look through them. + if (LoadSDNode *Ld = dyn_cast(Src)) { + if (!Ld->isVolatile()) + return ReachesChainWithoutSideEffects(Ld->getChain(), Dest, Depth+1); + } + return false; +} + SDOperand DAGCombiner::visitSTORE(SDNode *N) { StoreSDNode *ST = cast(N); SDOperand Chain = ST->getChain(); @@ -4250,10 +4278,12 @@ SDOperand DAGCombiner::visitSTORE(SDNode *N) { // If this is a load followed by a store to the same location, then the store // is dead/noop. if (LoadSDNode *Ld = dyn_cast(Value)) { - if (Chain.Val == Ld && Ld->getBasePtr() == Ptr && + if (Ld->getBasePtr() == Ptr && ST->getStoredVT() == Ld->getLoadedVT() && ST->getAddressingMode() == ISD::UNINDEXED && - ST->getStoredVT() == Ld->getLoadedVT() && - !ST->isVolatile()) { + !ST->isVolatile() && + // There can't be any side effects between the load and store, such as + // a call or store. + ReachesChainWithoutSideEffects(Chain, SDOperand(Ld, 1))) { // The store is dead, remove it. return Chain; } diff --git a/test/CodeGen/X86/longlong-deadload.ll b/test/CodeGen/X86/longlong-deadload.ll new file mode 100644 index 00000000000..a8e2c31d948 --- /dev/null +++ b/test/CodeGen/X86/longlong-deadload.ll @@ -0,0 +1,11 @@ +; RUN: llvm-as < %s | llc -march=x86 | not grep '4{(%...)} +; This should not load or store the top part of *P. + +define void @test(i64* %P) nounwind { +entry: + %tmp1 = load i64* %P, align 8 ; [#uses=1] + %tmp2 = xor i64 %tmp1, 1 ; [#uses=1] + store i64 %tmp2, i64* %P, align 8 + ret void +} +