6502/llvm-6502
1
0
Fork 0
mirror of https://github.com/c64scene-ar/llvm-6502.git synced 2024-09-30 19:55:11 +00:00
Code Issues Projects Releases Wiki Activity

ProfileData: Avoid unnecessary copies of CounterData

Browse Source 
We're currently copying CounterData from InstrProfWriter into the
OnDiskHashTable, even though we don't need to, and then carelessly
leaking those copies. A const pointer is much better here.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@207009 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Justin Bogner 2014-04-23 18:50:16 +00:00
parent 94a9772abc
commit 08a4d0b36f
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
lib/ProfileData/InstrProfWriter.cpp
View File

@ -27,8 +27,8 @@ public:
typedef StringRef key_type; typedef StringRef key_type;
typedef StringRef key_type_ref; typedef StringRef key_type_ref;
typedef InstrProfWriter::CounterData data_type; typedef const InstrProfWriter::CounterData *const data_type;
typedef const InstrProfWriter::CounterData &data_type_ref; typedef const InstrProfWriter::CounterData *const data_type_ref;
typedef uint64_t hash_value_type; typedef uint64_t hash_value_type;
typedef uint64_t offset_type; typedef uint64_t offset_type;
@ -45,7 +45,7 @@ public:
offset_type N = K.size(); offset_type N = K.size();
LE.write<offset_type>(N); LE.write<offset_type>(N);
offset_type M = (1 + V.Counts.size()) * sizeof(uint64_t); offset_type M = (1 + V->Counts.size()) * sizeof(uint64_t);
LE.write<offset_type>(M); LE.write<offset_type>(M);
return std::make_pair(N, M); return std::make_pair(N, M);
@ -59,8 +59,8 @@ public:
offset_type) { offset_type) {
using namespace llvm::support; using namespace llvm::support;
endian::Writer<little> LE(Out); endian::Writer<little> LE(Out);
LE.write<uint64_t>(V.Hash); LE.write<uint64_t>(V->Hash);
for (uint64_t I : V.Counts) for (uint64_t I : V->Counts)
LE.write<uint64_t>(I); LE.write<uint64_t>(I);
} }
}; };
@ -100,7 +100,7 @@ void InstrProfWriter::write(raw_fd_ostream &OS) {
// Populate the hash table generator. // Populate the hash table generator.
for (const auto &I : FunctionData) { for (const auto &I : FunctionData) {
Generator.insert(I.getKey(), I.getValue()); Generator.insert(I.getKey(), &I.getValue());
if (I.getValue().Counts[0] > MaxFunctionCount) if (I.getValue().Counts[0] > MaxFunctionCount)
MaxFunctionCount = I.getValue().Counts[0]; MaxFunctionCount = I.getValue().Counts[0];
} }