From 09b4588309f5ed1900d36633668933569247c20f Mon Sep 17 00:00:00 2001 From: Jiangning Liu Date: Thu, 27 Mar 2014 07:42:58 +0000 Subject: [PATCH] ARM: raise error message when complex SO expressions can't really be solved as a constant at compilation time. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204898 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Target/ARM/AsmParser/ARMAsmParser.cpp | 2 +- test/MC/ARM/label_offset.s | 8 ++++++++ 2 files changed, 9 insertions(+), 1 deletion(-) create mode 100644 test/MC/ARM/label_offset.s diff --git a/lib/Target/ARM/AsmParser/ARMAsmParser.cpp b/lib/Target/ARM/AsmParser/ARMAsmParser.cpp index e3215491fdf..83fedb70ebd 100644 --- a/lib/Target/ARM/AsmParser/ARMAsmParser.cpp +++ b/lib/Target/ARM/AsmParser/ARMAsmParser.cpp @@ -9357,7 +9357,7 @@ unsigned ARMAsmParser::validateTargetOperandClass(MCParsedAsmOperand *AsmOp, const MCExpr *SOExpr = Op->getImm(); int64_t Value; if (!SOExpr->EvaluateAsAbsolute(Value)) - return Match_Success; + return Match_InvalidOperand; assert((Value >= INT32_MIN && Value <= INT32_MAX) && "expression value must be representiable in 32 bits"); } diff --git a/test/MC/ARM/label_offset.s b/test/MC/ARM/label_offset.s new file mode 100644 index 00000000000..0aeb3b6ee69 --- /dev/null +++ b/test/MC/ARM/label_offset.s @@ -0,0 +1,8 @@ +@ RUN: not llvm-mc -triple=armv7-linux-gnuabi -filetype=obj < %s 2>&1 | FileCheck %s + +.text + cmp r2, #(l2 - l1) >> 6 +@ CHECK: error: invalid operand for instruction + +l1: +l2: