6502/llvm-6502
1
0
Fork 0
mirror of https://github.com/c64scene-ar/llvm-6502.git synced 2024-12-14 11:32:34 +00:00
Code Issues Projects Releases Wiki Activity

Fix a conversion from a forward iterator to a reverse iterator in

Browse Source 
MachineBasicBlock::SplitCriticalEdge. Since this is an iterator rather than
an instr_iterator, the isBundled() check only passes if getFirstTerminator()
returned end() and the garbage memory happens to lean that way.

Multiple successors can be present without any terminator instructions in the
case of exception handling with a fallthrough.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@175383 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Cameron Zwarich 2013-02-17 01:45:04 +00:00
parent f0b2535344
commit 0c22283598
1 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
lib/CodeGen/MachineBasicBlock.cpp
View File

@ -852,12 +852,13 @@ MachineBasicBlock::SplitCriticalEdge(MachineBasicBlock *Succ, Pass *P) {
// Update all intervals for registers whose uses may have been modified by
// updateTerminator().
iterator FirstTerminator = getFirstTerminator();
MachineInstr *FirstTerminatorMI = FirstTerminator;
if (FirstTerminatorMI->isBundled())
FirstTerminatorMI = getBundleStart(FirstTerminatorMI);
reverse_iterator PreTerminators =
(FirstTerminator == begin()) ? rend()
: reverse_iterator(FirstTerminatorMI);
reverse_iterator PreTerminators;
if (FirstTerminator == begin())
PreTerminators = rend();
else if (FirstTerminator == end())
PreTerminators = rbegin();
else
PreTerminators = reverse_iterator(FirstTerminator);
LIS->repairIntervalsInRange(this, rbegin(), PreTerminators, UsedRegs);
}