From 0d90962f29466d6fe1e7b15be6890d26cca77e0a Mon Sep 17 00:00:00 2001 From: Matt Arsenault Date: Fri, 29 Aug 2014 16:01:17 +0000 Subject: [PATCH] Make fabs safe to speculatively execute git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216736 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Analysis/ValueTracking.cpp | 1 + test/Transforms/SimplifyCFG/speculate-math.ll | 17 +++++++++++++++++ 2 files changed, 18 insertions(+) diff --git a/lib/Analysis/ValueTracking.cpp b/lib/Analysis/ValueTracking.cpp index ce945eb30ee..6409b85b1a0 100644 --- a/lib/Analysis/ValueTracking.cpp +++ b/lib/Analysis/ValueTracking.cpp @@ -2009,6 +2009,7 @@ bool llvm::isSafeToSpeculativelyExecute(const Value *V, case Intrinsic::sqrt: case Intrinsic::fma: case Intrinsic::fmuladd: + case Intrinsic::fabs: return true; // TODO: some fp intrinsics are marked as having the same error handling // as libm. They're safe to speculate when they won't error. diff --git a/test/Transforms/SimplifyCFG/speculate-math.ll b/test/Transforms/SimplifyCFG/speculate-math.ll index fa7976d0689..29583b6d6a0 100644 --- a/test/Transforms/SimplifyCFG/speculate-math.ll +++ b/test/Transforms/SimplifyCFG/speculate-math.ll @@ -3,6 +3,7 @@ declare float @llvm.sqrt.f32(float) nounwind readonly declare float @llvm.fma.f32(float, float, float) nounwind readonly declare float @llvm.fmuladd.f32(float, float, float) nounwind readonly +declare float @llvm.fabs.f32(float) nounwind readonly ; CHECK-LABEL: @sqrt_test( ; CHECK: select @@ -21,6 +22,22 @@ test_sqrt.exit: ; preds = %cond.else.i, %entry ret void } +; CHECK-LABEL: @fabs_test( +; CHECK: select +define void @fabs_test(float addrspace(1)* noalias nocapture %out, float %a) nounwind { +entry: + %cmp.i = fcmp olt float %a, 0.000000e+00 + br i1 %cmp.i, label %test_fabs.exit, label %cond.else.i + +cond.else.i: ; preds = %entry + %0 = tail call float @llvm.fabs.f32(float %a) nounwind readnone + br label %test_fabs.exit + +test_fabs.exit: ; preds = %cond.else.i, %entry + %cond.i = phi float [ %0, %cond.else.i ], [ 0x7FF8000000000000, %entry ] + store float %cond.i, float addrspace(1)* %out, align 4 + ret void +} ; CHECK-LABEL: @fma_test( ; CHECK: select