From 0db68f4e3a8be1641dbba72a41baa6ff1b5dd6af Mon Sep 17 00:00:00 2001 From: Daniel Dunbar Date: Tue, 11 Aug 2009 05:00:25 +0000 Subject: [PATCH] llvm-mc/X86: Parse '*' correctly (in the way the matcher expects). git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@78642 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Target/X86/AsmParser/X86AsmParser.cpp | 18 +++++++----------- test/MC/AsmParser/x86_instructions.s | 3 +++ 2 files changed, 10 insertions(+), 11 deletions(-) diff --git a/lib/Target/X86/AsmParser/X86AsmParser.cpp b/lib/Target/X86/AsmParser/X86AsmParser.cpp index c3e292eb7e9..46432118671 100644 --- a/lib/Target/X86/AsmParser/X86AsmParser.cpp +++ b/lib/Target/X86/AsmParser/X86AsmParser.cpp @@ -263,17 +263,6 @@ bool X86ATTAsmParser::ParseOperand(X86Operand &Op) { Op = X86Operand::CreateImm(Val); return false; } - case AsmToken::Star: - getLexer().Lex(); // Eat the star. - - if (getLexer().is(AsmToken::Register)) { - if (ParseRegister(Op)) - return true; - } else if (ParseMemOperand(Op)) - return true; - - // FIXME: Note the '*' in the operand for use by the matcher. - return false; } } @@ -406,6 +395,13 @@ bool X86ATTAsmParser::ParseInstruction(const StringRef &Name, MCInst &Inst) { SMLoc Loc = getLexer().getTok().getLoc(); if (getLexer().isNot(AsmToken::EndOfStatement)) { + + // Parse '*' modifier. + if (getLexer().is(AsmToken::Star)) { + getLexer().Lex(); // Eat the star. + Operands.push_back(X86Operand::CreateToken("*")); + } + // Read the first operand. Operands.push_back(X86Operand()); if (ParseOperand(Operands.back())) diff --git a/test/MC/AsmParser/x86_instructions.s b/test/MC/AsmParser/x86_instructions.s index 436e2e08fb8..0d3367a03fa 100644 --- a/test/MC/AsmParser/x86_instructions.s +++ b/test/MC/AsmParser/x86_instructions.s @@ -49,3 +49,6 @@ // RUN: grep {MCInst(opcode=.*, operands=.reg:21, reg:0, reg:19.)} %t subl %eax, %ebx +// FIXME: Check that this matches the correct instruction. +// RUN: grep {MCInst(opcode=.*, operands=.reg:80.)} %t + call *%rax