mirror of
https://github.com/c64scene-ar/llvm-6502.git
synced 2026-04-20 16:17:38 +00:00
GC poses hazards to the inliner. Consider:
define void @f() {
...
call i32 @g()
...
}
define void @g() {
...
}
The hazards are:
- @f and @g have GC, but they differ GC. Inlining is invalid. This
may never occur.
- @f has no GC, but @g does. g's GC must be propagated to @f.
The other scenarios are safe:
- @f and @g have the same GC.
- @f and @g have no GC.
- @g has no GC.
This patch adds inliner checks for the former two scenarios.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@45351 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
@@ -201,6 +201,19 @@ bool llvm::InlineFunction(CallSite CS, CallGraph *CG, const TargetData *TD) {
|
||||
BasicBlock *OrigBB = TheCall->getParent();
|
||||
Function *Caller = OrigBB->getParent();
|
||||
|
||||
|
||||
// GC poses two hazards to inlining, which only occur when the callee has GC:
|
||||
// 1. If the caller has no GC, then the callee's GC must be propagated to the
|
||||
// caller.
|
||||
// 2. If the caller has a differing GC, it is invalid to inline.
|
||||
if (CalledFunc->hasCollector()) {
|
||||
if (!Caller->hasCollector())
|
||||
Caller->setCollector(CalledFunc->getCollector());
|
||||
else if (CalledFunc->getCollector() != Caller->getCollector())
|
||||
return false;
|
||||
}
|
||||
|
||||
|
||||
// Get an iterator to the last basic block in the function, which will have
|
||||
// the new function inlined after it.
|
||||
//
|
||||
|
||||
Reference in New Issue
Block a user