From 0f193b8a6846dab25323788638e760ae03b7cd87 Mon Sep 17 00:00:00 2001 From: Chris Lattner Date: Wed, 25 Jan 2012 01:27:20 +0000 Subject: [PATCH] Use the right method to get the # elements in a CDS. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@148897 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Analysis/ConstantFolding.cpp | 4 ++-- lib/Analysis/ValueTracking.cpp | 2 +- lib/CodeGen/AsmPrinter/AsmPrinter.cpp | 6 +++--- lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp | 2 +- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/lib/Analysis/ConstantFolding.cpp b/lib/Analysis/ConstantFolding.cpp index 7ee716fdf62..43b3af2ac52 100644 --- a/lib/Analysis/ConstantFolding.cpp +++ b/lib/Analysis/ConstantFolding.cpp @@ -351,7 +351,7 @@ static bool ReadDataFromGlobal(Constant *C, uint64_t ByteOffset, uint64_t EltSize = CDS->getElementByteSize(); uint64_t Index = ByteOffset / EltSize; uint64_t Offset = ByteOffset - Index * EltSize; - for (; Index != CDS->getType()->getNumElements(); ++Index) { + for (unsigned e = CDS->getNumElements(); Index != e; ++Index) { if (!ReadDataFromGlobal(CDS->getElementAsConstant(Index), Offset, CurPtr, BytesLeft, TD)) return false; @@ -1042,7 +1042,7 @@ Constant *llvm::ConstantFoldLoadThroughGEPIndices(Constant *C, return 0; C = CA->getOperand(IdxVal); } else if (ConstantDataSequential *CDS=dyn_cast(C)){ - if (IdxVal >= CDS->getType()->getNumElements()) + if (IdxVal >= CDS->getNumElements()) return 0; C = CDS->getElementAsConstant(IdxVal); } else if (ConstantVector *CV = dyn_cast(C)) { diff --git a/lib/Analysis/ValueTracking.cpp b/lib/Analysis/ValueTracking.cpp index 753ec189944..ca55fcbc6ed 100644 --- a/lib/Analysis/ValueTracking.cpp +++ b/lib/Analysis/ValueTracking.cpp @@ -105,7 +105,7 @@ void llvm::ComputeMaskedBits(Value *V, const APInt &Mask, // each element. KnownZero.setAllBits(); KnownOne.setAllBits(); APInt Elt(KnownZero.getBitWidth(), 0); - for (unsigned i = 0, e = CDS->getType()->getNumElements(); i != e; ++i) { + for (unsigned i = 0, e = CDS->getNumElements(); i != e; ++i) { Elt = CDS->getElementAsInteger(i); KnownZero &= ~Elt; KnownOne &= Elt; diff --git a/lib/CodeGen/AsmPrinter/AsmPrinter.cpp b/lib/CodeGen/AsmPrinter/AsmPrinter.cpp index ff6da1248bb..0e6c613f93b 100644 --- a/lib/CodeGen/AsmPrinter/AsmPrinter.cpp +++ b/lib/CodeGen/AsmPrinter/AsmPrinter.cpp @@ -1630,7 +1630,7 @@ static void EmitGlobalConstantDataSequential(const ConstantDataSequential *CDS, // Otherwise, emit the values in successive locations. unsigned ElementByteSize = CDS->getElementByteSize(); if (isa(CDS->getElementType())) { - for (unsigned i = 0, e = CDS->getType()->getNumElements(); i != e; ++i) { + for (unsigned i = 0, e = CDS->getNumElements(); i != e; ++i) { AP.OutStreamer.EmitIntValue(CDS->getElementAsInteger(i), ElementByteSize, AddrSpace); } @@ -1643,7 +1643,7 @@ static void EmitGlobalConstantDataSequential(const ConstantDataSequential *CDS, CDS->getElementType()->isDoubleTy()); if (ElementByteSize == 4) { - for (unsigned i = 0, e = CDS->getType()->getNumElements(); i != e; ++i) { + for (unsigned i = 0, e = CDS->getNumElements(); i != e; ++i) { union { float F; uint32_t I; @@ -1657,7 +1657,7 @@ static void EmitGlobalConstantDataSequential(const ConstantDataSequential *CDS, return; } - for (unsigned i = 0, e = CDS->getType()->getNumElements(); i != e; ++i) { + for (unsigned i = 0, e = CDS->getNumElements(); i != e; ++i) { union { double F; uint64_t I; diff --git a/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp b/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp index cd9bec11bd0..7731f7c6b28 100644 --- a/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp +++ b/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp @@ -1059,7 +1059,7 @@ SDValue SelectionDAGBuilder::getValueImpl(const Value *V) { if (const ConstantDataSequential *CDS = dyn_cast(C)) { SmallVector Ops; - for (unsigned i = 0, e = CDS->getType()->getNumElements(); i != e; ++i) { + for (unsigned i = 0, e = CDS->getNumElements(); i != e; ++i) { SDNode *Val = getValue(CDS->getElementAsConstant(i)).getNode(); // Add each leaf value from the operand to the Constants list // to form a flattened list of all the values.