From 0fed4c6a45fdcc93ba77afd8d7bad4c6ca3aec07 Mon Sep 17 00:00:00 2001 From: Matt Arsenault Date: Thu, 13 Nov 2014 20:23:36 +0000 Subject: [PATCH] R600/SI: Fix definition for s_cselect_b32 These were directly using the old base instruction class, and specifying the wrong register classes for operands. The operands can be the other special inputs besides SGPRs. The op name was also being directly used for the asm string, so this was printed without any operands. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@221921 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Target/R600/SIInstrInfo.td | 5 +++++ lib/Target/R600/SIInstructions.td | 5 ++--- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/lib/Target/R600/SIInstrInfo.td b/lib/Target/R600/SIInstrInfo.td index 0ea08ea3fbb..6e098cd1dc1 100644 --- a/lib/Target/R600/SIInstrInfo.td +++ b/lib/Target/R600/SIInstrInfo.td @@ -340,6 +340,11 @@ class SOP2_32 op, string opName, list pattern> : SOP2 < opName#" $dst, $src0, $src1", pattern >; +class SOP2_SELECT_32 op, string opName, list pattern> : SOP2 < + op, (outs SReg_32:$dst), (ins SSrc_32:$src0, SSrc_32:$src1, SCCReg:$scc), + opName#" $dst, $src0, $src1 [$scc]", pattern +>; + class SOP2_64 op, string opName, list pattern> : SOP2 < op, (outs SReg_64:$dst), (ins SSrc_64:$src0, SSrc_64:$src1), opName#" $dst, $src0, $src1", pattern diff --git a/lib/Target/R600/SIInstructions.td b/lib/Target/R600/SIInstructions.td index 2d730b50399..14ad4529ab8 100644 --- a/lib/Target/R600/SIInstructions.td +++ b/lib/Target/R600/SIInstructions.td @@ -214,9 +214,8 @@ def S_MAX_U32 : SOP2_32 <0x00000009, "s_max_u32", [(set i32:$dst, (AMDGPUumax i32:$src0, i32:$src1))] >; -def S_CSELECT_B32 : SOP2 < - 0x0000000a, (outs SReg_32:$dst), - (ins SReg_32:$src0, SReg_32:$src1, SCCReg:$scc), "s_cselect_b32", +def S_CSELECT_B32 : SOP2_SELECT_32 < + 0x0000000a, "s_cselect_b32", [] >;