From 106aa731bf86c632a6362497742c6df7bce61a07 Mon Sep 17 00:00:00 2001 From: "Michael J. Spencer" Date: Fri, 3 Dec 2010 17:53:43 +0000 Subject: [PATCH] Support/FileSystem: Add remove implementation. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@120817 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Support/Unix/PathV2.inc | 14 ++++++++++++++ lib/Support/Windows/PathV2.inc | 19 +++++++++++++++++++ unittests/Support/Path.cpp | 3 ++- 3 files changed, 35 insertions(+), 1 deletion(-) diff --git a/lib/Support/Unix/PathV2.inc b/lib/Support/Unix/PathV2.inc index 985dde7426a..e6972f83363 100644 --- a/lib/Support/Unix/PathV2.inc +++ b/lib/Support/Unix/PathV2.inc @@ -186,6 +186,20 @@ error_code create_symlink(const Twine &to, const Twine &from) { return make_error_code(errc::success); } +error_code remove(const Twine &path, bool &existed) { + SmallString<128> path_storage; + StringRef p = path.toNullTerminatedStringRef(path_storage); + + if (::remove(p.begin()) == -1) { + if (errno != ENOENT) + return error_code(errno, system_category()); + existed = false; + } else + existed = true; + + return make_error_code(errc::success); +} + error_code exists(const Twine &path, bool &result) { SmallString<128> path_storage; StringRef p = path.toNullTerminatedStringRef(path_storage); diff --git a/lib/Support/Windows/PathV2.inc b/lib/Support/Windows/PathV2.inc index 98db5fdf388..c86c24e811e 100644 --- a/lib/Support/Windows/PathV2.inc +++ b/lib/Support/Windows/PathV2.inc @@ -252,6 +252,25 @@ error_code create_symlink(const Twine &to, const Twine &from) { return make_error_code(errc::success); } +error_code remove(const Twine &path, bool &existed) { + SmallString<128> path_storage; + SmallVector path_utf16; + + if (error_code ec = UTF8ToUTF16(path.toStringRef(path_storage), + path_utf16)) + return ec; + + if (!::DeleteFileW(path_utf16.begin())) { + error_code ec = make_error_code(windows_error(::GetLastError())); + if (ec != make_error_code(windows_error::file_not_found)) + return ec; + existed = false; + } else + existed = true; + + return make_error_code(errc::success); +} + error_code exists(const Twine &path, bool &result) { SmallString<128> path_storage; SmallVector path_utf16; diff --git a/unittests/Support/Path.cpp b/unittests/Support/Path.cpp index d19bf4a2efc..40e62811d02 100644 --- a/unittests/Support/Path.cpp +++ b/unittests/Support/Path.cpp @@ -128,7 +128,8 @@ TEST(Support, Path) { EXPECT_TRUE(TempFileExists); ::close(FileDescriptor); - ::remove(TempPath.c_str()); + ASSERT_FALSE(fs::remove(Twine(TempPath), TempFileExists)); + EXPECT_TRUE(TempFileExists); ASSERT_FALSE(fs::exists(Twine(TempPath), TempFileExists)); EXPECT_FALSE(TempFileExists);