From 11ecfc88eb9747682cd32a80be46336e11074bb4 Mon Sep 17 00:00:00 2001 From: Mark Seaborn Date: Wed, 29 Jan 2014 00:20:44 +0000 Subject: [PATCH] Remove unnecessary call to pthread_mutexattr_setpshared() The default value of this attribute is PTHREAD_PROCESS_PRIVATE, so there's no point in calling pthread_mutexattr_setpshared() to set that. See: http://pubs.opengroup.org/onlinepubs/9699919799/functions/pthread_mutexattr_getpshared.html This removes some ifdefs that tend to need to be extended for other platforms (e.g. for NaCl). Note that this call was in the first implementation of Mutex, added in r22403, so it doesn't appear to have been added in response to a performance problem. Differential Revision: http://llvm-reviews.chandlerc.com/D2633 git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@200360 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Support/Mutex.cpp | 7 ------- 1 file changed, 7 deletions(-) diff --git a/lib/Support/Mutex.cpp b/lib/Support/Mutex.cpp index 4e4a026b2f0..37c9d73daee 100644 --- a/lib/Support/Mutex.cpp +++ b/lib/Support/Mutex.cpp @@ -59,13 +59,6 @@ MutexImpl::MutexImpl( bool recursive) errorcode = pthread_mutexattr_settype(&attr, kind); assert(errorcode == 0); -#if !defined(__FreeBSD__) && !defined(__OpenBSD__) && !defined(__NetBSD__) && \ - !defined(__DragonFly__) && !defined(__Bitrig__) - // Make it a process local mutex - errorcode = pthread_mutexattr_setpshared(&attr, PTHREAD_PROCESS_PRIVATE); - assert(errorcode == 0); -#endif - // Initialize the mutex errorcode = pthread_mutex_init(mutex, &attr); assert(errorcode == 0);