mirror of
https://github.com/c64scene-ar/llvm-6502.git
synced 2025-07-16 11:24:39 +00:00
Object/COFF: Define coff_symbol_generic.
If you only need Name and Value fields in the COFF symbol, you don't need to distinguish 32 bit and 64 bit COFF symbols. These fields start at the same offsets and have the same size. This data strucutre is one pointer smaller than COFFSymbolRef thus slightly efficient. I'll use this class in LLD as we create millions of LLD symbol objects that currently contain COFFSymbolRef. Shaving off 8 byte (or 4 byte on 32 bit) from that class actually matters becasue of the number of objects we create in LLD. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@241024 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
@@ -249,6 +249,15 @@ struct coff_symbol {
|
||||
typedef coff_symbol<support::ulittle16_t> coff_symbol16;
|
||||
typedef coff_symbol<support::ulittle32_t> coff_symbol32;
|
||||
|
||||
// Contains only common parts of coff_symbol16 and coff_symbol32.
|
||||
struct coff_symbol_generic {
|
||||
union {
|
||||
char ShortName[COFF::NameSize];
|
||||
StringTableOffset Offset;
|
||||
} Name;
|
||||
support::ulittle32_t Value;
|
||||
};
|
||||
|
||||
class COFFSymbolRef {
|
||||
public:
|
||||
COFFSymbolRef(const coff_symbol16 *CS) : CS16(CS), CS32(nullptr) {}
|
||||
@@ -259,6 +268,12 @@ public:
|
||||
return CS16 ? static_cast<const void *>(CS16) : CS32;
|
||||
}
|
||||
|
||||
const coff_symbol_generic *getGeneric() const {
|
||||
if (CS16)
|
||||
return reinterpret_cast<const coff_symbol_generic *>(CS16);
|
||||
return reinterpret_cast<const coff_symbol_generic *>(CS32);
|
||||
}
|
||||
|
||||
friend bool operator<(COFFSymbolRef A, COFFSymbolRef B) {
|
||||
return A.getRawPtr() < B.getRawPtr();
|
||||
}
|
||||
@@ -744,6 +759,8 @@ public:
|
||||
return std::error_code();
|
||||
}
|
||||
std::error_code getSymbolName(COFFSymbolRef Symbol, StringRef &Res) const;
|
||||
std::error_code getSymbolName(const coff_symbol_generic *Symbol,
|
||||
StringRef &Res) const;
|
||||
|
||||
ArrayRef<uint8_t> getSymbolAuxData(COFFSymbolRef Symbol) const;
|
||||
|
||||
|
Reference in New Issue
Block a user