From 1486ae626f1af5c2797f4d13e9c57b3a0e473811 Mon Sep 17 00:00:00 2001 From: Nick Lewycky Date: Wed, 25 Jan 2012 03:20:12 +0000 Subject: [PATCH] Fix assert("msg"). Fix unused-variable warnings complaining about VT used only in asserts. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@148910 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/VMCore/Constants.cpp | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/lib/VMCore/Constants.cpp b/lib/VMCore/Constants.cpp index 0fcce094084..6cb36bf21b3 100644 --- a/lib/VMCore/Constants.cpp +++ b/lib/VMCore/Constants.cpp @@ -1506,8 +1506,9 @@ Constant *ConstantExpr::getPtrToInt(Constant *C, Type *DstTy) { assert(DstTy->getScalarType()->isIntegerTy() && "PtrToInt destination must be integer or integer vector"); assert(isa(C->getType()) == isa(DstTy)); - if (VectorType *VT = dyn_cast(C->getType())) - assert(VT->getNumElements() == cast(DstTy)->getNumElements() && + if (isa(C->getType())) + assert(cast(C->getType())->getNumElements() == + cast(DstTy)->getNumElements() && "Invalid cast between a different number of vector elements"); return getFoldedCast(Instruction::PtrToInt, C, DstTy); } @@ -1518,8 +1519,9 @@ Constant *ConstantExpr::getIntToPtr(Constant *C, Type *DstTy) { assert(DstTy->getScalarType()->isPointerTy() && "IntToPtr destination must be a pointer or pointer vector"); assert(isa(C->getType()) == isa(DstTy)); - if (VectorType *VT = dyn_cast(C->getType())) - assert(VT->getNumElements() == cast(DstTy)->getNumElements() && + if (isa(C->getType())) + assert(cast(C->getType())->getNumElements() == + cast(DstTy)->getNumElements() && "Invalid cast between a different number of vector elements"); return getFoldedCast(Instruction::IntToPtr, C, DstTy); } @@ -2218,7 +2220,8 @@ APFloat ConstantDataSequential::getElementAsAPFloat(unsigned Elt) const { const char *EltPtr = getElementPointer(Elt); switch (getElementType()->getTypeID()) { - default: assert("Accessor can only be used when element is float/double!"); + default: + assert(0 && "Accessor can only be used when element is float/double!"); case Type::FloatTyID: return APFloat(*(float*)EltPtr); case Type::DoubleTyID: return APFloat(*(double*)EltPtr); }