From 17347ac3f18147c5fff5f5d6c8e634c08841c7ba Mon Sep 17 00:00:00 2001 From: Daniel Sanders Date: Fri, 6 Mar 2015 11:40:28 +0000 Subject: [PATCH] Merging r225521: ------------------------------------------------------------------------ r225521 | tomatabacu | 2015-01-09 15:00:30 +0000 (Fri, 09 Jan 2015) | 1 line [mips] Add comment which explains why we need to change the assembler options before and after inline asm blocks. NFC. ------------------------------------------------------------------------ git-svn-id: https://llvm.org/svn/llvm-project/llvm/branches/release_35@231463 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Target/Mips/MipsAsmPrinter.cpp | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/lib/Target/Mips/MipsAsmPrinter.cpp b/lib/Target/Mips/MipsAsmPrinter.cpp index 94b7c0d9807..fac3f79491b 100644 --- a/lib/Target/Mips/MipsAsmPrinter.cpp +++ b/lib/Target/Mips/MipsAsmPrinter.cpp @@ -725,6 +725,12 @@ void MipsAsmPrinter::emitInlineAsmStart( const MCSubtargetInfo &StartInfo) const { MipsTargetStreamer &TS = getTargetStreamer(); + // GCC's choice of assembler options for inline assembly code ('at', 'macro' + // and 'reorder') is different from LLVM's choice for generated code ('noat', + // 'nomacro' and 'noreorder'). + // In order to maintain compatibility with inline assembly code which depends + // on GCC's assembler options being used, we have to switch to those options + // for the duration of the inline assembly block and then switch back. TS.emitDirectiveSetPush(); TS.emitDirectiveSetAt(); TS.emitDirectiveSetMacro();