6502/llvm-6502
1
0
Fork 0
mirror of https://github.com/c64scene-ar/llvm-6502.git synced 2025-02-01 02:33:44 +00:00
Code Issues Projects Releases Wiki Activity

op_iterator-ify some loops, low hanging fruit only, there is more

Browse Source 
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@52246 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Gabor Greif 2008-06-12 21:37:33 +00:00
parent 933b5065e5
commit 177dd3ff11
1 changed files with 21 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

40
lib/Transforms/Scalar/InstructionCombining.cpp
View File

@ -122,8 +122,8 @@ namespace {
/// the work lists because they might get more simplified now. /// the work lists because they might get more simplified now.
/// ///
void AddUsesToWorkList(Instruction &I) { void AddUsesToWorkList(Instruction &I) {
for (unsigned i = 0, e = I.getNumOperands(); i != e; ++i) for (User::op_iterator i = I.op_begin(), e = I.op_end(); i != e; ++i)
if (Instruction *Op = dyn_cast<Instruction>(I.getOperand(i))) if (Instruction *Op = dyn_cast<Instruction>(*i))
AddToWorkList(Op); AddToWorkList(Op);
} }
@ -136,11 +136,11 @@ namespace {
Value *AddSoonDeadInstToWorklist(Instruction &I, unsigned op) { Value *AddSoonDeadInstToWorklist(Instruction &I, unsigned op) {
Value *R = I.getOperand(op); Value *R = I.getOperand(op);
for (unsigned i = 0, e = I.getNumOperands(); i != e; ++i) for (User::op_iterator i = I.op_begin(), e = I.op_end(); i != e; ++i)
if (Instruction *Op = dyn_cast<Instruction>(I.getOperand(i))) { if (Instruction *Op = dyn_cast<Instruction>(*i)) {
AddToWorkList(Op); AddToWorkList(Op);
// Set the operand to undef to drop the use. // Set the operand to undef to drop the use.
I.setOperand(i, UndefValue::get(Op->getType())); *i = UndefValue::get(Op->getType());
} }
return R; return R;
@ -4585,8 +4585,9 @@ static Value *EmitGEPOffset(User *GEP, Instruction &I, InstCombiner &IC) {
unsigned IntPtrWidth = TD.getPointerSizeInBits(); unsigned IntPtrWidth = TD.getPointerSizeInBits();
uint64_t PtrSizeMask = ~0ULL >> (64-IntPtrWidth); uint64_t PtrSizeMask = ~0ULL >> (64-IntPtrWidth);
for (unsigned i = 1, e = GEP->getNumOperands(); i != e; ++i, ++GTI) { for (User::op_iterator i = GEP->op_begin() + 1, e = GEP->op_end(); i != e;
Value *Op = GEP->getOperand(i); ++i, ++GTI) {
Value *Op = *i;
uint64_t Size = TD.getABITypeSize(GTI.getIndexedType()) & PtrSizeMask; uint64_t Size = TD.getABITypeSize(GTI.getIndexedType()) & PtrSizeMask;
if (ConstantInt *OpC = dyn_cast<ConstantInt>(Op)) { if (ConstantInt *OpC = dyn_cast<ConstantInt>(Op)) {
if (OpC->isZero()) continue; if (OpC->isZero()) continue;
@ -8286,9 +8287,9 @@ static unsigned EnforceKnownAlignment(Value *V,
case Instruction::GetElementPtr: { case Instruction::GetElementPtr: {
// If all indexes are zero, it is just the alignment of the base pointer. // If all indexes are zero, it is just the alignment of the base pointer.
bool AllZeroOperands = true; bool AllZeroOperands = true;
for (unsigned i = 1, e = U->getNumOperands(); i != e; ++i) for (User::op_iterator i = U->op_begin(), e = U->op_end(); i != e; ++i)
if (!isa<Constant>(U->getOperand(i)) || if (!isa<Constant>(*i) ||
!cast<Constant>(U->getOperand(i))->isNullValue()) { !cast<Constant>(*i)->isNullValue()) {
AllZeroOperands = false; AllZeroOperands = false;
break; break;
} }
@ -9536,9 +9537,10 @@ Instruction *InstCombiner::visitGetElementPtrInst(GetElementPtrInst &GEP) {
bool MadeChange = false; bool MadeChange = false;
gep_type_iterator GTI = gep_type_begin(GEP); gep_type_iterator GTI = gep_type_begin(GEP);
for (unsigned i = 1, e = GEP.getNumOperands(); i != e; ++i, ++GTI) { for (User::op_iterator i = GEP.op_begin() + 1, e = GEP.op_end();
i != e; ++i, ++GTI) {
if (isa<SequentialType>(*GTI)) { if (isa<SequentialType>(*GTI)) {
if (CastInst *CI = dyn_cast<CastInst>(GEP.getOperand(i))) { if (CastInst *CI = dyn_cast<CastInst>(*i)) {
if (CI->getOpcode() == Instruction::ZExt || if (CI->getOpcode() == Instruction::ZExt ||
CI->getOpcode() == Instruction::SExt) { CI->getOpcode() == Instruction::SExt) {
const Type *SrcTy = CI->getOperand(0)->getType(); const Type *SrcTy = CI->getOperand(0)->getType();
@ -9546,7 +9548,7 @@ Instruction *InstCombiner::visitGetElementPtrInst(GetElementPtrInst &GEP) {
// is a 32-bit pointer target. // is a 32-bit pointer target.
if (SrcTy->getPrimitiveSizeInBits() >= TD->getPointerSizeInBits()) { if (SrcTy->getPrimitiveSizeInBits() >= TD->getPointerSizeInBits()) {
MadeChange = true; MadeChange = true;
GEP.setOperand(i, CI->getOperand(0)); *i = CI->getOperand(0);
} }
} }
} }
@ -9554,15 +9556,15 @@ Instruction *InstCombiner::visitGetElementPtrInst(GetElementPtrInst &GEP) {
// to what we need. If the incoming value needs a cast instruction, // to what we need. If the incoming value needs a cast instruction,
// insert it. This explicit cast can make subsequent optimizations more // insert it. This explicit cast can make subsequent optimizations more
// obvious. // obvious.
Value *Op = GEP.getOperand(i); Value *Op = *i;
if (TD->getTypeSizeInBits(Op->getType()) > TD->getPointerSizeInBits()) { if (TD->getTypeSizeInBits(Op->getType()) > TD->getPointerSizeInBits()) {
if (Constant *C = dyn_cast<Constant>(Op)) { if (Constant *C = dyn_cast<Constant>(Op)) {
GEP.setOperand(i, ConstantExpr::getTrunc(C, TD->getIntPtrType())); *i = ConstantExpr::getTrunc(C, TD->getIntPtrType());
MadeChange = true; MadeChange = true;
} else { } else {
Op = InsertCastBefore(Instruction::Trunc, Op, TD->getIntPtrType(), Op = InsertCastBefore(Instruction::Trunc, Op, TD->getIntPtrType(),
GEP); GEP);
GEP.setOperand(i, Op); *i = Op;
MadeChange = true; MadeChange = true;
} }
} }
@ -10717,11 +10719,11 @@ static std::vector<unsigned> getShuffleMask(const ShuffleVectorInst *SVI) {
std::vector<unsigned> Result; std::vector<unsigned> Result;
const ConstantVector *CP = cast<ConstantVector>(SVI->getOperand(2)); const ConstantVector *CP = cast<ConstantVector>(SVI->getOperand(2));
for (unsigned i = 0, e = CP->getNumOperands(); i != e; ++i) for (User::const_op_iterator i = CP->op_begin(), e = CP->op_end(); i!=e; ++i)
if (isa<UndefValue>(CP->getOperand(i))) if (isa<UndefValue>(*i))
Result.push_back(NElts*2); // undef -> 8 Result.push_back(NElts*2); // undef -> 8
else else
Result.push_back(cast<ConstantInt>(CP->getOperand(i))->getZExtValue()); Result.push_back(cast<ConstantInt>(*i)->getZExtValue());
return Result; return Result;
} }