6502/llvm-6502
1
0
Fork 0
mirror of https://github.com/c64scene-ar/llvm-6502.git synced 2024-12-14 11:32:34 +00:00
Code Issues Projects Releases Wiki Activity

Add a GlobalAlias::isValidLinkage to reduce code duplication.

Browse Source 
Thanks to Reid Kleckner for the suggestion.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@192298 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Rafael Espindola 2013-10-09 16:07:32 +00:00
parent 3b73dea538
commit 1a525e8c80
3 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
include/llvm/IR/GlobalAlias.h
View File

@ -81,6 +81,11 @@ public:
return const_cast<GlobalAlias *>(this)->resolveAliasedGlobal(stopOnWeak); return const_cast<GlobalAlias *>(this)->resolveAliasedGlobal(stopOnWeak);
} }
static bool isValidLinkage(LinkageTypes L) {
return isExternalLinkage(L) || isLocalLinkage(L) ||
isWeakLinkage(L) || isLinkOnceLinkage(L);
}
// Methods for support type inquiry through isa, cast, and dyn_cast: // Methods for support type inquiry through isa, cast, and dyn_cast:
static inline bool classof(const Value *V) { static inline bool classof(const Value *V) {
return V->getValueID() == Value::GlobalAliasVal; return V->getValueID() == Value::GlobalAliasVal;

5
lib/AsmParser/LLParser.cpp
View File

@ -634,10 +634,7 @@ bool LLParser::ParseAlias(const std::string &Name, LocTy NameLoc,
GlobalValue::LinkageTypes Linkage = (GlobalValue::LinkageTypes) L; GlobalValue::LinkageTypes Linkage = (GlobalValue::LinkageTypes) L;
if(!GlobalValue::isExternalLinkage(Linkage) && if(!GlobalAlias::isValidLinkage(Linkage))
!GlobalValue::isLocalLinkage(Linkage) &&
!GlobalValue::isWeakLinkage(Linkage) &&
!GlobalValue::isLinkOnceLinkage(Linkage))
return Error(LinkageLoc, "invalid linkage type for alias"); return Error(LinkageLoc, "invalid linkage type for alias");
Constant *Aliasee; Constant *Aliasee;

3
lib/IR/Verifier.cpp
View File

@ -529,8 +529,7 @@ void Verifier::visitGlobalVariable(GlobalVariable &GV) {
void Verifier::visitGlobalAlias(GlobalAlias &GA) { void Verifier::visitGlobalAlias(GlobalAlias &GA) {
Assert1(!GA.getName().empty(), Assert1(!GA.getName().empty(),
"Alias name cannot be empty!", &GA); "Alias name cannot be empty!", &GA);
Assert1(GA.hasExternalLinkage() || GA.hasLocalLinkage() || Assert1(GlobalAlias::isValidLinkage(GA.getLinkage()),
GA.hasWeakLinkage() || GA.hasLinkOnceLinkage(),
"Alias should have external or external weak linkage!", &GA); "Alias should have external or external weak linkage!", &GA);
Assert1(GA.getAliasee(), Assert1(GA.getAliasee(),
"Aliasee cannot be NULL!", &GA); "Aliasee cannot be NULL!", &GA);