From 1c90c6f1c530e22aea5be055004b2517e77a0f02 Mon Sep 17 00:00:00 2001 From: Chris Lattner Date: Wed, 16 Sep 2009 00:17:39 +0000 Subject: [PATCH] Eliminate AsmPrinter::EmitExternalGlobal, inlining its (now) one implementation into its one caller. This eliminates a totally awesome and gratuitous hack where we casted a Function* to GlobalVariable*. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@81967 91177308-0d34-0410-b5e6-96231b3b80d8 --- include/llvm/CodeGen/AsmPrinter.h | 4 ---- lib/CodeGen/AsmPrinter/AsmPrinter.cpp | 7 ------- lib/CodeGen/AsmPrinter/DwarfException.cpp | 2 +- 3 files changed, 1 insertion(+), 12 deletions(-) diff --git a/include/llvm/CodeGen/AsmPrinter.h b/include/llvm/CodeGen/AsmPrinter.h index 8404841b5a3..375b260c135 100644 --- a/include/llvm/CodeGen/AsmPrinter.h +++ b/include/llvm/CodeGen/AsmPrinter.h @@ -159,10 +159,6 @@ namespace llvm { /// bool isVerbose() const { return VerboseAsm; } - /// EmitExternalGlobal - Emit the external reference to a global variable. - /// Should be overridden if an indirect reference should be used. - virtual void EmitExternalGlobal(const GlobalVariable *GV); - /// getCurrentFunctionEHName - Called to return the CurrentFnEHName. /// std::string getCurrentFunctionEHName(const MachineFunction *MF) const; diff --git a/lib/CodeGen/AsmPrinter/AsmPrinter.cpp b/lib/CodeGen/AsmPrinter/AsmPrinter.cpp index a457421b907..e5f0dba2b97 100644 --- a/lib/CodeGen/AsmPrinter/AsmPrinter.cpp +++ b/lib/CodeGen/AsmPrinter/AsmPrinter.cpp @@ -509,13 +509,6 @@ void AsmPrinter::EmitXXStructorList(Constant *List) { } } -/// EmitExternalGlobal - Emit the external reference to a global variable. -/// Should be overridden if an indirect reference should be used. -void AsmPrinter::EmitExternalGlobal(const GlobalVariable *GV) { - O << Mang->getMangledName(GV); -} - - //===----------------------------------------------------------------------===// /// LEB 128 number encoding. diff --git a/lib/CodeGen/AsmPrinter/DwarfException.cpp b/lib/CodeGen/AsmPrinter/DwarfException.cpp index abd2e6fe80d..f8e8009cd0c 100644 --- a/lib/CodeGen/AsmPrinter/DwarfException.cpp +++ b/lib/CodeGen/AsmPrinter/DwarfException.cpp @@ -163,7 +163,7 @@ void DwarfException::EmitCIE(const Function *Personality, unsigned Index) { O << MAI->getData32bitsDirective(); O << MAI->getPersonalityPrefix(); - Asm->EmitExternalGlobal((const GlobalVariable *)(Personality)); + O << Asm->Mang->getMangledName(Personality); O << MAI->getPersonalitySuffix(); if (strcmp(MAI->getPersonalitySuffix(), "+4@GOTPCREL"))