From 1d50fea817304c928b3e1797676b7b374cc1a343 Mon Sep 17 00:00:00 2001 From: Pirama Arumuga Nainar Date: Wed, 22 Apr 2015 18:04:12 +0000 Subject: [PATCH] Fix correctness check for test_vec_fpextend_double Summary: Remove the CHECK-DAG calls introduced in r235341, and add a comment that this test may break due to scheduling variations. This patch completes the fix discussed in http://reviews.llvm.org/D8804 Reviewers: dsanders, srhines Subscribers: llvm-commits Differential Revision: http://reviews.llvm.org/D9178 git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@235530 91177308-0d34-0410-b5e6-96231b3b80d8 --- test/CodeGen/Mips/fp16-promote.ll | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/test/CodeGen/Mips/fp16-promote.ll b/test/CodeGen/Mips/fp16-promote.ll index 410352fded5..2ac46e02807 100644 --- a/test/CodeGen/Mips/fp16-promote.ll +++ b/test/CodeGen/Mips/fp16-promote.ll @@ -57,14 +57,16 @@ define <4 x float> @test_vec_fpext_float(<4 x half>* %p) #0 { ret <4 x float> %b } +; This test is not robust against variations in instruction scheduling. +; See the discussion in http://reviews.llvm.org/D8804 ; CHECK-LIBCALL-LABEL: test_vec_fpext_double: -; CHECK-LIBCALL-DAG: %call16(__gnu_h2f_ieee) -; CHECK-LIBCALL-DAG: %call16(__gnu_h2f_ieee) -; CHECK-LIBCALL-DAG: %call16(__gnu_h2f_ieee) -; CHECK-LIBCALL-DAG: %call16(__gnu_h2f_ieee) -; CHECK-LIBCALL-DAG: cvt.d.s -; CHECK-LIBCALL-DAG: cvt.d.s -; CHECK-LIBCALL-DAG: cvt.d.s +; CHECK-LIBCALL: %call16(__gnu_h2f_ieee) +; CHECK-LIBCALL: %call16(__gnu_h2f_ieee) +; CHECK-LIBCALL: %call16(__gnu_h2f_ieee) +; CHECK-LIBCALL: cvt.d.s +; CHECK-LIBCALL: cvt.d.s +; CHECK-LIBCALL: cvt.d.s +; CHECK-LIBCALL: %call16(__gnu_h2f_ieee) ; CHECK-LIBCALL: cvt.d.s define <4 x double> @test_vec_fpext_double(<4 x half>* %p) #0 { %a = load <4 x half>, <4 x half>* %p, align 8