6502/llvm-6502
1
0
Fork 0
mirror of https://github.com/c64scene-ar/llvm-6502.git synced 2025-06-22 10:24:26 +00:00
Code Issues Projects Releases Wiki Activity

BitcodeReader: Only create one basic block for each blockaddress

Browse Source 
Block address forward-references are implemented by creating a
`BasicBlock` ahead of time that gets inserted in the `Function` when
it's eventually encountered.

However, if the same blockaddress was used in two separate functions
that were parsed *before* the referenced function (and the blockaddress
was never used at global scope), two separate basic blocks would get
created, one of which would be forgotten creating invalid IR.

This commit changes the forward-reference logic to create only one basic
block (and always return the same blockaddress).

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@215805 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Duncan P. N. Exon Smith
2014-08-16 01:54:37 +00:00
parent 1e97329f27
commit 1d8c9d95bf
3 changed files with 32 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
test/Bitcode/blockaddress.ll
View File

@ -44,3 +44,17 @@ here:
end:
ret void
}
; Check a blockaddress taken in two separate functions before the referenced
; function.
define i8* @take1() {
ret i8* blockaddress(@taken, %bb)
}
define i8* @take2() {
ret i8* blockaddress(@taken, %bb)
}
define void @taken() {
unreachable
bb:
unreachable
}