Add a createUniqueFile function and switch llvm's users of unique_file.

This function is complementary to createTemporaryFile. It handles the case were
the unique file is *not* temporary: we will rename it in the end. Since we
will rename it, the file has to be in the same filesystem as the final
destination and we don't prepend the system temporary directory.

This has a small semantic difference from unique_file: the default mode is 0666.
This matches the behavior of most unix tools. For example, with this change
lld now produces files with the same permissions as ld. I will add a test
of this change when I port clang over to createUniqueFile (next commit).

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@185726 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Rafael Espindola
2013-07-05 21:01:08 +00:00
parent cd56727b55
commit 200c748a86
9 changed files with 60 additions and 21 deletions

View File

@ -65,8 +65,8 @@ error_code FileOutputBuffer::create(StringRef FilePath,
// Create new file in same directory but with random name.
SmallString<128> TempFilePath;
int FD;
EC = sys::fs::unique_file(Twine(FilePath) + ".tmp%%%%%%%",
FD, TempFilePath, false, 0644);
EC = sys::fs::createUniqueFile(Twine(FilePath) + ".tmp%%%%%%%",
FD, TempFilePath);
if (EC)
return EC;