6502/llvm-6502
1
0
Fork 0
mirror of https://github.com/c64scene-ar/llvm-6502.git synced 2024-12-13 04:30:23 +00:00
Code Issues Projects Releases Wiki Activity

[AArch64] Fix v2i8->i16 bitcast legalization.

Browse Source 
r213378 improved f16 bitcasts, so that they go directly through subregs,
instead of through the stack.  That code now causes an assertion failure
for bitcasts from other 16-bits types (most importantly v2i8).

Correct that by doing the custom lowering for i16 bitcasts only when the
input is an f16.

Part of PR21549.

Differential Revision: http://reviews.llvm.org/D6307


git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@223074 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Ahmed Bougacha 2014-12-01 20:52:32 +00:00
parent 787a41926a
commit 217a4a87ce
2 changed files with 19 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
lib/Target/AArch64/AArch64ISelLowering.cpp
View File

@ -8697,13 +8697,12 @@ bool AArch64TargetLowering::getPostIndexedAddressParts(
static void ReplaceBITCASTResults(SDNode *N, SmallVectorImpl<SDValue> &Results,
SelectionDAG &DAG) {
if (N->getValueType(0) != MVT::i16)
return;
SDLoc DL(N);
SDValue Op = N->getOperand(0);
assert(Op.getValueType() == MVT::f16 &&
"Inconsistent bitcast? Only 16-bit types should be i16 or f16");
if (N->getValueType(0) != MVT::i16 || Op.getValueType() != MVT::f16)
return;
Op = SDValue(
DAG.getMachineNode(TargetOpcode::INSERT_SUBREG, DL, MVT::f32,
DAG.getUNDEF(MVT::i32), Op,

15
test/CodeGen/AArch64/bitcast-v2i8.ll Normal file
View File

@ -0,0 +1,15 @@
; RUN: llc < %s -mtriple=aarch64-apple-ios | FileCheck %s
; Part of PR21549: going through the stack isn't ideal but is correct.
define i16 @test_bitcast_v2i8_to_i16(<2 x i8> %a) {
; CHECK-LABEL: test_bitcast_v2i8_to_i16
; CHECK: mov.s [[WREG_HI:w[0-9]+]], v0[1]
; CHECK-NEXT: fmov [[WREG_LO:w[0-9]+]], s0
; CHECK-NEXT: strb [[WREG_HI]], [sp, #15]
; CHECK-NEXT: strb [[WREG_LO]], [sp, #14]
; CHECK-NEXT: ldrh w0, [sp, #14]
%aa = bitcast <2 x i8> %a to i16
ret i16 %aa
}