6502/llvm-6502
1
0
Fork 0
mirror of https://github.com/c64scene-ar/llvm-6502.git synced 2025-08-15 22:28:18 +00:00
Code Issues Projects Releases Wiki Activity

Let StructRetPromotion check if it's users are really calling it and not

Browse Source 
passing its pointer. Fixes test with added testcase.


git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@51991 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Matthijs Kooijman
2008-06-05 08:48:32 +00:00
parent 41335411a8
commit 257da0a7fc
2 changed files with 28 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
lib/Transforms/IPO/StructRetPromotion.cpp
View File

@@ -158,6 +158,10 @@ bool SRETPromotion::isSafeToUpdateAllCallers(Function *F) {
for (Value::use_iterator FnUseI = F->use_begin(), FnUseE = F->use_end(); for (Value::use_iterator FnUseI = F->use_begin(), FnUseE = F->use_end();
FnUseI != FnUseE; ++FnUseI) { FnUseI != FnUseE; ++FnUseI) {
// The function is passed in as an argument to (possibly) another function,
// we can't change it!
if (FnUseI.getOperandNo() != 0)
return false;
CallSite CS = CallSite::get(*FnUseI); CallSite CS = CallSite::get(*FnUseI);
Instruction *Call = CS.getInstruction(); Instruction *Call = CS.getInstruction();

24
test/Transforms/SRETPromotion/2008-06-04-function-pointer-passing.ll Normal file
View File

@@ -0,0 +1,24 @@
; This test lures sretpromotion into promoting the sret argument of foo, even
; when the function is used as an argument to bar. It used to not check for
; this, assuming that all users of foo were direct calls, resulting in an
; assertion failure later on.
; We're mainly testing for opt not to crash, but we'll check to see if the sret
; attribute is still there for good measure.
; RUN: llvm-as < %s | opt -sretpromotion | llvm-dis | grep sret
%struct.S = type <{ i32, i32 }>
define i32 @main() {
entry:
%tmp = alloca %struct.S ; <%struct.S*> [#uses=1]
call void @bar( %struct.S* sret %tmp, void (%struct.S*, ...)* @foo )
ret i32 undef
}
declare void @bar(%struct.S* sret , void (%struct.S*, ...)*)
define internal void @foo(%struct.S* sret %agg.result, ...) {
entry:
ret void
}