6502/llvm-6502
1
0
Fork 0
mirror of https://github.com/c64scene-ar/llvm-6502.git synced 2024-11-02 07:11:49 +00:00
Code Issues Projects Releases Wiki Activity

Fix a rather nasty regression from r150690: LHS != RHS does not imply LHS->stripPointerCasts() != RHS->stripPointerCasts().

Browse Source 
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@150863 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Eli Friedman 2012-02-18 03:29:25 +00:00
parent 5bfd969208
commit 2c3acb0e27
2 changed files with 12 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
lib/Analysis/InstructionSimplify.cpp
View File

@ -1593,10 +1593,11 @@ static Value *SimplifyICmpInst(unsigned Predicate, Value *LHS, Value *RHS,
// the compare, and if only one of them is then we moved it to RHS already. // the compare, and if only one of them is then we moved it to RHS already.
Value *LHSPtr = LHS->stripPointerCasts(); Value *LHSPtr = LHS->stripPointerCasts();
Value *RHSPtr = RHS->stripPointerCasts(); Value *RHSPtr = RHS->stripPointerCasts();
if (LHSPtr == RHSPtr)
return ConstantInt::get(ITy, CmpInst::isTrueWhenEqual(Pred));
if (isa<AllocaInst>(LHSPtr) && (isa<GlobalValue>(RHSPtr) || if (isa<AllocaInst>(LHSPtr) && (isa<GlobalValue>(RHSPtr) ||
isa<AllocaInst>(RHSPtr) || isa<AllocaInst>(RHSPtr) ||
isa<ConstantPointerNull>(RHSPtr))) isa<ConstantPointerNull>(RHSPtr)))
// We already know that LHS != RHS.
return ConstantInt::get(ITy, CmpInst::isFalseWhenEqual(Pred)); return ConstantInt::get(ITy, CmpInst::isFalseWhenEqual(Pred));
// If we are comparing with zero then try hard since this is a common case. // If we are comparing with zero then try hard since this is a common case.

10
test/Transforms/InstSimplify/compare.ll
View File

@ -30,6 +30,16 @@ define i1 @gep() {
; CHECK-NEXT: ret i1 false ; CHECK-NEXT: ret i1 false
} }
define i1 @gep2() {
; CHECK: @gep2
%a = alloca [3 x i8], align 8
%x = getelementptr inbounds [3 x i8]* %a, i32 0, i32 0
%y = getelementptr inbounds [3 x i8]* %a, i32 0, i32 0
%cmp = icmp eq i8* %x, %y
ret i1 %cmp
; CHECK-NEXT: ret i1 true
}
define i1 @zext(i32 %x) { define i1 @zext(i32 %x) {
; CHECK: @zext ; CHECK: @zext
%e1 = zext i32 %x to i64 %e1 = zext i32 %x to i64