From 2d0a77a1a44a69f77db7f9c4cea9f9b82d541735 Mon Sep 17 00:00:00 2001 From: Dan Gohman Date: Fri, 23 May 2008 22:47:52 +0000 Subject: [PATCH] It turns out there are only 3 non-first-class type kinds left now, so it's simpler for isFirstClassType to use a negative test. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@51511 91177308-0d34-0410-b5e6-96231b3b80d8 --- include/llvm/Type.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/include/llvm/Type.h b/include/llvm/Type.h index 743a0189db1..b029212de49 100644 --- a/include/llvm/Type.h +++ b/include/llvm/Type.h @@ -216,8 +216,9 @@ public: /// is a valid type for a Value. /// inline bool isFirstClassType() const { - return isSingleValueType() || - ID == StructTyID || ID == ArrayTyID; + // There are more first-class kinds than non-first-class kinds, so a + // negative test is simpler than a positive one. + return ID != FunctionTyID && ID != VoidTyID && ID != OpaqueTyID; } /// isSingleValueType - Return true if the type is a valid type for a