From 2e6baf626d2096eade89e5305bc09e369a761516 Mon Sep 17 00:00:00 2001 From: Chris Lattner Date: Wed, 16 Aug 2006 01:23:31 +0000 Subject: [PATCH] Bugfixes for smallvector when the element size is small and N is small. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@29720 91177308-0d34-0410-b5e6-96231b3b80d8 --- include/llvm/ADT/SmallVector.h | 21 +++++++++++++++++---- 1 file changed, 17 insertions(+), 4 deletions(-) diff --git a/include/llvm/ADT/SmallVector.h b/include/llvm/ADT/SmallVector.h index ae258846e74..66e268cf046 100644 --- a/include/llvm/ADT/SmallVector.h +++ b/include/llvm/ADT/SmallVector.h @@ -228,17 +228,30 @@ class SmallVector : public SmallVectorImpl { /// InlineElts - These are 'N-1' elements that are stored inline in the body /// of the vector. The extra '1' element is stored in SmallVectorImpl. typedef typename SmallVectorImpl::U U; - U InlineElts[(sizeof(T)*N+sizeof(U)-1)/sizeof(U) - 1]; + enum { + // MinUs - The number of U's require to cover N T's. + MinUs = (sizeof(T)*N+sizeof(U)-1)/sizeof(U), + + // NumInlineEltsElts - The number of elements actually in this array. There + // is already one in the parent class, and we have to round up to avoid + // having a zero-element array. + NumInlineEltsElts = (MinUs - 1) > 0 ? (MinUs - 1) : 1, + + // NumTsAvailable - The number of T's we actually have space for, which may + // be more than N due to rounding. + NumTsAvailable = (NumInlineEltsElts+1)*sizeof(U) / sizeof(T) + }; + U InlineElts[NumInlineEltsElts]; public: - SmallVector() : SmallVectorImpl(N) { + SmallVector() : SmallVectorImpl(NumTsAvailable) { } template - SmallVector(ItTy S, ItTy E) : SmallVectorImpl(N) { + SmallVector(ItTy S, ItTy E) : SmallVectorImpl(NumTsAvailable) { append(S, E); } - SmallVector(const SmallVector &RHS) : SmallVectorImpl(N) { + SmallVector(const SmallVector &RHS) : SmallVectorImpl(NumTsAvailable) { operator=(RHS); } };