From 305b8a5f62c9d027f3d8a870fc12fc2abf69aeea Mon Sep 17 00:00:00 2001 From: Lauro Ramos Venancio Date: Wed, 25 Apr 2007 14:50:40 +0000 Subject: [PATCH] remember to emit weak reference in one more case. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@36438 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Target/ARM/ARMAsmPrinter.cpp | 7 ++++++- test/CodeGen/ARM/weak2.ll | 18 ++++++++++++++++++ 2 files changed, 24 insertions(+), 1 deletion(-) create mode 100644 test/CodeGen/ARM/weak2.ll diff --git a/lib/Target/ARM/ARMAsmPrinter.cpp b/lib/Target/ARM/ARMAsmPrinter.cpp index 6822e632824..6e9a9038dc4 100644 --- a/lib/Target/ARM/ARMAsmPrinter.cpp +++ b/lib/Target/ARM/ARMAsmPrinter.cpp @@ -639,8 +639,13 @@ void ARMAsmPrinter::printCPInstOperand(const MachineInstr *MI, int OpNo, if (MCPE.isMachineConstantPoolEntry()) EmitMachineConstantPoolValue(MCPE.Val.MachineCPVal); - else + else { EmitGlobalConstant(MCPE.Val.ConstVal); + // remember to emit the weak reference + if (const GlobalValue *GV = dyn_cast(MCPE.Val.ConstVal)) + if (GV->hasExternalWeakLinkage()) + ExtWeakSymbols.insert(GV); + } } } diff --git a/test/CodeGen/ARM/weak2.ll b/test/CodeGen/ARM/weak2.ll new file mode 100644 index 00000000000..a57a76707ce --- /dev/null +++ b/test/CodeGen/ARM/weak2.ll @@ -0,0 +1,18 @@ +; RUN: llvm-as < %s | llc -march=arm | grep .weak + +define i32 @f(i32 %a) { +entry: + %tmp2 = icmp eq i32 %a, 0 ; [#uses=1] + %t.0 = select i1 %tmp2, i32 (...)* null, i32 (...)* @test_weak ; [#uses=2] + %tmp5 = icmp eq i32 (...)* %t.0, null ; [#uses=1] + br i1 %tmp5, label %UnifiedReturnBlock, label %cond_true8 + +cond_true8: ; preds = %entry + %tmp10 = tail call i32 (...)* %t.0( ) ; [#uses=1] + ret i32 %tmp10 + +UnifiedReturnBlock: ; preds = %entry + ret i32 250 +} + +declare extern_weak i32 @test_weak(...)