6502/llvm-6502
1
0
Fork 0
mirror of https://github.com/c64scene-ar/llvm-6502.git synced 2025-08-14 15:28:20 +00:00
Code Issues Projects Releases Wiki Activity

Use move semantics if possible to construct ConstantRanges.

Browse Source 
Arithmetic on ConstantRanges creates a lot of large temporary APInts that
benefit from move semantics.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@186091 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Benjamin Kramer
2013-07-11 15:37:27 +00:00
parent 71857ccdb8
commit 318b7cc7f1
2 changed files with 16 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
include/llvm/Support/ConstantRange.h
View File

@@ -42,6 +42,14 @@ namespace llvm {
class ConstantRange { class ConstantRange {
APInt Lower, Upper; APInt Lower, Upper;
#if LLVM_HAS_RVALUE_REFERENCES
// If we have move semantics, pass APInts by value and move them into place.
typedef APInt APIntMoveTy;
#else
// Otherwise pass by const ref to save one copy.
typedef const APInt &APIntMoveTy;
#endif
public: public:
/// Initialize a full (the default) or empty set for the specified bit width. /// Initialize a full (the default) or empty set for the specified bit width.
/// ///
@@ -49,12 +57,12 @@ public:
/// Initialize a range to hold the single specified value. /// Initialize a range to hold the single specified value.
/// ///
ConstantRange(const APInt &Value); ConstantRange(APIntMoveTy Value);
/// @brief Initialize a range of values explicitly. This will assert out if /// @brief Initialize a range of values explicitly. This will assert out if
/// Lower==Upper and Lower != Min or Max value for its type. It will also /// Lower==Upper and Lower != Min or Max value for its type. It will also
/// assert out if the two APInt's are not the same bit width. /// assert out if the two APInt's are not the same bit width.
ConstantRange(const APInt &Lower, const APInt &Upper); ConstantRange(APIntMoveTy Lower, APIntMoveTy Upper);
/// makeICmpRegion - Produce the smallest range that contains all values that /// makeICmpRegion - Produce the smallest range that contains all values that
/// might satisfy the comparison specified by Pred when compared to any value /// might satisfy the comparison specified by Pred when compared to any value

11
lib/Support/ConstantRange.cpp
View File

@@ -38,13 +38,14 @@ ConstantRange::ConstantRange(uint32_t BitWidth, bool Full) {
/// Initialize a range to hold the single specified value. /// Initialize a range to hold the single specified value.
/// ///
ConstantRange::ConstantRange(const APInt &V) : Lower(V), Upper(V + 1) {} ConstantRange::ConstantRange(APIntMoveTy V)
: Lower(llvm_move(V)), Upper(Lower + 1) {}
ConstantRange::ConstantRange(const APInt &L, const APInt &U) : ConstantRange::ConstantRange(APIntMoveTy L, APIntMoveTy U)
Lower(L), Upper(U) { : Lower(llvm_move(L)), Upper(llvm_move(U)) {
assert(L.getBitWidth() == U.getBitWidth() && assert(Lower.getBitWidth() == Upper.getBitWidth() &&
"ConstantRange with unequal bit widths"); "ConstantRange with unequal bit widths");
assert((L != U || (L.isMaxValue() || L.isMinValue())) && assert((Lower != Upper || (Lower.isMaxValue() || Lower.isMinValue())) &&
"Lower == Upper, but they aren't min or max value!"); "Lower == Upper, but they aren't min or max value!");
} }