From 325be7c608a37d87e4f3d731e11fa3dd34f529b5 Mon Sep 17 00:00:00 2001 From: Anton Korobeynikov Date: Thu, 6 Sep 2007 17:21:48 +0000 Subject: [PATCH] Proper handle case, when aliasee is external weak symbol referenced only by alias itself. Also, fix a case, when target doesn't have weak symbols supported. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@41746 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/CodeGen/AsmPrinter.cpp | 19 +++++++++++++------ test/CodeGen/X86/2007-09-06-ExtWeakAliasee.ll | 4 ++++ 2 files changed, 17 insertions(+), 6 deletions(-) create mode 100644 test/CodeGen/X86/2007-09-06-ExtWeakAliasee.ll diff --git a/lib/CodeGen/AsmPrinter.cpp b/lib/CodeGen/AsmPrinter.cpp index 9387847cff6..fa6f5691fc3 100644 --- a/lib/CodeGen/AsmPrinter.cpp +++ b/lib/CodeGen/AsmPrinter.cpp @@ -132,13 +132,11 @@ bool AsmPrinter::doFinalization(Module &M) { I!=E; ++I) { std::string Name = Mang->getValueName(I); std::string Target; + + const GlobalValue *GV = cast(I->getAliasedGlobal()); + Target = Mang->getValueName(GV); - if (const GlobalValue *GV = I->getAliasedGlobal()) - Target = Mang->getValueName(GV); - else - assert(0 && "Unsupported aliasee"); - - if (I->hasExternalLinkage()) + if (I->hasExternalLinkage() || !TAI->getWeakRefDirective()) O << "\t.globl\t" << Name << "\n"; else if (I->hasWeakLinkage()) O << TAI->getWeakRefDirective() << Name << "\n"; @@ -146,6 +144,15 @@ bool AsmPrinter::doFinalization(Module &M) { assert(0 && "Invalid alias linkage"); O << TAI->getSetDirective() << Name << ", " << Target << "\n"; + + // If the aliasee has external weak linkage it can be referenced only by + // alias itself. In this case it can be not in ExtWeakSymbols list. Emit + // weak reference in such case. + if (GV->hasExternalWeakLinkage()) + if (TAI->getWeakRefDirective()) + O << TAI->getWeakRefDirective() << Target << "\n"; + else + O << "\t.globl\t" << Target << "\n"; } } diff --git a/test/CodeGen/X86/2007-09-06-ExtWeakAliasee.ll b/test/CodeGen/X86/2007-09-06-ExtWeakAliasee.ll new file mode 100644 index 00000000000..4f95b7603ba --- /dev/null +++ b/test/CodeGen/X86/2007-09-06-ExtWeakAliasee.ll @@ -0,0 +1,4 @@ +; RUN: llvm-as < %s | llc -march=x86 | grep weak | count 2 +@__gthrw_pthread_once = alias weak i32 (i32*, void ()*)* @pthread_once ; [#uses=0] + +declare extern_weak i32 @pthread_once(i32*, void ()*)