diff --git a/lib/CodeGen/RegAllocFast.cpp b/lib/CodeGen/RegAllocFast.cpp index 8fc10b4f6db..c6214140026 100644 --- a/lib/CodeGen/RegAllocFast.cpp +++ b/lib/CodeGen/RegAllocFast.cpp @@ -372,15 +372,23 @@ void RAFast::usePhysReg(MachineOperand &MO) { case regDisabled: break; case regReserved: - assert(TRI->isSuperRegister(PhysReg, Alias) && + // Either PhysReg is a subregister of Alias and we mark the + // whole register as free, or PhysReg is the superregister of + // Alias and we mark all the aliases as disabled before freeing + // PhysReg. + // In the latter case, since PhysReg was disabled, this means that + // its value is defined only by physical sub-registers. This check + // is performed by the assert of the default case in this loop. + // Note: The value of the superregister may only be partial + // defined, that is why regDisabled is a valid state for aliases. + assert((TRI->isSuperRegister(PhysReg, Alias) || + TRI->isSuperRegister(Alias, PhysReg)) && "Instruction is not using a subregister of a reserved register"); - // Leave the superregister in the working set. - PhysRegState[Alias] = regFree; - MO.getParent()->addRegisterKilled(Alias, TRI, true); - return; + // Fall through. case regFree: if (TRI->isSuperRegister(PhysReg, Alias)) { // Leave the superregister in the working set. + PhysRegState[Alias] = regFree; MO.getParent()->addRegisterKilled(Alias, TRI, true); return; } @@ -1023,8 +1031,7 @@ void RAFast::AllocateBasicBlock() { if (TargetRegisterInfo::isPhysicalRegister(Reg)) { if (!MRI->isAllocatable(Reg)) continue; - definePhysReg(MI, Reg, (MO.isImplicit() || MO.isDead()) ? - regFree : regReserved); + definePhysReg(MI, Reg, MO.isDead() ? regFree : regReserved); continue; } LiveRegMap::iterator LRI = defineVirtReg(MI, i, Reg, CopySrc); diff --git a/test/CodeGen/X86/crash-O0.ll b/test/CodeGen/X86/crash-O0.ll index 956d43b4e89..df8eaaf442b 100644 --- a/test/CodeGen/X86/crash-O0.ll +++ b/test/CodeGen/X86/crash-O0.ll @@ -1,4 +1,4 @@ -; RUN: llc -O0 -relocation-model=pic -disable-fp-elim < %s +; RUN: llc -O0 -relocation-model=pic -disable-fp-elim < %s | FileCheck %s target datalayout = "e-p:64:64:64-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:64:64-f32:32:32-f64:64:64-v64:64:64-v128:128:128-a0:0:64-s0:64:64-f80:128:128-n8:16:32:64" target triple = "x86_64-apple-darwin10" @@ -29,3 +29,23 @@ entry: "41": ; preds = %"39" unreachable } + +; When using fast isel, sdiv is lowered into a sequence of CQO + DIV64. +; CQO defines implicitly AX and DIV64 uses it implicitly too. +; When an instruction gets between those two, RegAllocFast was reusing +; AX for the vreg defined in between and the compiler crashed. +; +; An instruction gets between CQO and DIV64 because the load is folded +; into the division but it requires a sign extension. +; PR21700 +; CHECK-LABEL: addressModeWith32bitIndex: +; CHECK: cqto +; CHECK-NEXT: movslq +; CHECK-NEXT: idivq +; CHECK: retq +define i64 @addressModeWith32bitIndex(i32 %V) { + %gep = getelementptr i64* null, i32 %V + %load = load i64* %gep + %sdiv = sdiv i64 0, %load + ret i64 %sdiv +}