mirror of
https://github.com/c64scene-ar/llvm-6502.git
synced 2025-07-25 13:24:46 +00:00
Switch lowering: extract jump tables and bit tests before building binary tree (PR22262)
This is a re-commit of r235101, which also fixes the problems with the previous patch: - Switches with only a default case and non-fallthrough were handled incorrectly - The previous patch tickled a bug in PowerPC Early-Return Creation which is fixed here. > This is a major rewrite of the SelectionDAG switch lowering. The previous code > would lower switches as a binary tre, discovering clusters of cases > suitable for lowering by jump tables or bit tests as it went along. To increase > the likelihood of finding jump tables, the binary tree pivot was selected to > maximize case density on both sides of the pivot. > > By not selecting the pivot in the middle, the binary trees would not always > be balanced, leading to performance problems in the generated code. > > This patch rewrites the lowering to search for clusters of cases > suitable for jump tables or bit tests first, and then builds the binary > tree around those clusters. This way, the binary tree will always be balanced. > > This has the added benefit of decoupling the different aspects of the lowering: > tree building and jump table or bit tests finding are now easier to tweak > separately. > > For example, this will enable us to balance the tree based on profile info > in the future. > > The algorithm for finding jump tables is quadratic, whereas the previous algorithm > was O(n log n) for common cases, and quadratic only in the worst-case. This > doesn't seem to be major problem in practice, e.g. compiling a file consisting > of a 10k-case switch was only 30% slower, and such large switches should be rare > in practice. Compiling e.g. gcc.c showed no compile-time difference. If this > does turn out to be a problem, we could limit the search space of the algorithm. > > This commit also disables all optimizations during switch lowering in -O0. > > Differential Revision: http://reviews.llvm.org/D8649 git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@235560 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
@@ -151,12 +151,13 @@ protected:
|
||||
if (Changed && !ReturnMBB.hasAddressTaken()) {
|
||||
// We now might be able to merge this blr-only block into its
|
||||
// by-layout predecessor.
|
||||
if (ReturnMBB.pred_size() == 1 &&
|
||||
(*ReturnMBB.pred_begin())->isLayoutSuccessor(&ReturnMBB)) {
|
||||
// Move the blr into the preceding block.
|
||||
if (ReturnMBB.pred_size() == 1) {
|
||||
MachineBasicBlock &PrevMBB = **ReturnMBB.pred_begin();
|
||||
PrevMBB.splice(PrevMBB.end(), &ReturnMBB, I);
|
||||
PrevMBB.removeSuccessor(&ReturnMBB);
|
||||
if (PrevMBB.isLayoutSuccessor(&ReturnMBB) && PrevMBB.canFallThrough()) {
|
||||
// Move the blr into the preceding block.
|
||||
PrevMBB.splice(PrevMBB.end(), &ReturnMBB, I);
|
||||
PrevMBB.removeSuccessor(&ReturnMBB);
|
||||
}
|
||||
}
|
||||
|
||||
if (ReturnMBB.pred_empty())
|
||||
|
Reference in New Issue
Block a user