6502/llvm-6502
1
0
Fork 0
mirror of https://github.com/c64scene-ar/llvm-6502.git synced 2024-12-23 15:29:51 +00:00
Code Issues Projects Releases Wiki Activity

Remove #uses comments from functions: they we're padded out to column 50

Browse Source 
and were potentially confusing for externally visible functions.

going further, remove the "<i8**> [#uses=3]" comments entirely. They
add a lot of noise, confuse people about what the IR is, and don't add 
any particular value.  When the types are long it makes it really really
hard to read IR.

If someone is interested in this sort of thing, the right way to do this
is to implement an AsmAnnotationWriter that produces the same output, and
add a flag to llvm-dis (only) to produce this output.



git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@112894 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Chris Lattner 2010-09-02 22:41:24 +00:00
parent 571c15c6de
commit 39653a4e6c
1 changed files with 4 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
lib/VMCore/AsmWriter.cpp
View File

@ -1635,11 +1635,10 @@ void AssemblyWriter::printFunction(const Function *F) {
if (F->hasGC()) if (F->hasGC())
Out << " gc \"" << F->getGC() << '"'; Out << " gc \"" << F->getGC() << '"';
if (F->isDeclaration()) { if (F->isDeclaration()) {
Out << " ; [#uses=" << F->getNumUses() << "]\n"; // Output # uses Out << '\n';
} else { } else {
Out << " { ; [#uses=" << F->getNumUses() << ']'; // Output # uses Out << " {";
// Output all of the function's basic blocks.
// Output all of its basic blocks... for the function
for (Function::const_iterator I = F->begin(), E = F->end(); I != E; ++I) for (Function::const_iterator I = F->begin(), E = F->end(); I != E; ++I)
printBasicBlock(I); printBasicBlock(I);
@ -1688,7 +1687,7 @@ void AssemblyWriter::printBasicBlock(const BasicBlock *BB) {
Out.PadToColumn(50); Out.PadToColumn(50);
Out << "; Error: Block without parent!"; Out << "; Error: Block without parent!";
} else if (BB != &BB->getParent()->getEntryBlock()) { // Not the entry block? } else if (BB != &BB->getParent()->getEntryBlock()) { // Not the entry block?
// Output predecessors for the block... // Output predecessors for the block.
Out.PadToColumn(50); Out.PadToColumn(50);
Out << ";"; Out << ";";
const_pred_iterator PI = pred_begin(BB), PE = pred_end(BB); const_pred_iterator PI = pred_begin(BB), PE = pred_end(BB);
@ -1726,13 +1725,6 @@ void AssemblyWriter::printInfoComment(const Value &V) {
AnnotationWriter->printInfoComment(V, Out); AnnotationWriter->printInfoComment(V, Out);
return; return;
} }
if (V.getType()->isVoidTy()) return;
Out.PadToColumn(50);
Out << "; <";
TypePrinter.print(V.getType(), Out);
Out << "> [#uses=" << V.getNumUses() << ']'; // Output # uses
} }
// This member is called for each Instruction in a function.. // This member is called for each Instruction in a function..