diff --git a/lib/Target/CellSPU/SPUInstrBuilder.h b/lib/Target/CellSPU/SPUInstrBuilder.h index 00721d1b97b..5e268f8767c 100644 --- a/lib/Target/CellSPU/SPUInstrBuilder.h +++ b/lib/Target/CellSPU/SPUInstrBuilder.h @@ -38,18 +38,6 @@ addFrameReference(const MachineInstrBuilder &MIB, int FI, int Offset = 0, return MIB.addFrameIndex(FI).addImm(Offset); } -/// addConstantPoolReference - This function is used to add a reference to the -/// base of a constant value spilled to the per-function constant pool. The -/// reference has base register ConstantPoolIndex offset which is retained until -/// either machine code emission or assembly output. This allows an optional -/// offset to be added as well. -/// -inline const MachineInstrBuilder& -addConstantPoolReference(const MachineInstrBuilder &MIB, unsigned CPI, - int Offset = 0) { - return MIB.addImm(Offset).addConstantPoolIndex(CPI); -} - } // End llvm namespace #endif diff --git a/lib/Target/IA64/IA64InstrBuilder.h b/lib/Target/IA64/IA64InstrBuilder.h index 51b3744312e..a5d4dca530f 100644 --- a/lib/Target/IA64/IA64InstrBuilder.h +++ b/lib/Target/IA64/IA64InstrBuilder.h @@ -34,18 +34,6 @@ addFrameReference(const MachineInstrBuilder &MIB, int FI, int Offset = 0, return MIB.addFrameIndex(FI).addImm(Offset); } -/// addConstantPoolReference - This function is used to add a reference to the -/// base of a constant value spilled to the per-function constant pool. The -/// reference has base register ConstantPoolIndex offset which is retained until -/// either machine code emission or assembly output. This allows an optional -/// offset to be added as well. -/// -inline const MachineInstrBuilder& -addConstantPoolReference(const MachineInstrBuilder &MIB, unsigned CPI, - int Offset = 0) { - return MIB.addImm(Offset).addConstantPoolIndex(CPI); -} - } // End llvm namespace #endif diff --git a/lib/Target/PowerPC/PPCInstrBuilder.h b/lib/Target/PowerPC/PPCInstrBuilder.h index edb5103875d..1de69116cd5 100644 --- a/lib/Target/PowerPC/PPCInstrBuilder.h +++ b/lib/Target/PowerPC/PPCInstrBuilder.h @@ -38,18 +38,6 @@ addFrameReference(const MachineInstrBuilder &MIB, int FI, int Offset = 0, return MIB.addFrameIndex(FI).addImm(Offset); } -/// addConstantPoolReference - This function is used to add a reference to the -/// base of a constant value spilled to the per-function constant pool. The -/// reference has base register ConstantPoolIndex offset which is retained until -/// either machine code emission or assembly output. This allows an optional -/// offset to be added as well. -/// -inline const MachineInstrBuilder& -addConstantPoolReference(const MachineInstrBuilder &MIB, unsigned CPI, - int Offset = 0) { - return MIB.addImm(Offset).addConstantPoolIndex(CPI); -} - } // End llvm namespace #endif diff --git a/lib/Target/X86/X86FastISel.cpp b/lib/Target/X86/X86FastISel.cpp index bf939ab0fb6..211afd5fc87 100644 --- a/lib/Target/X86/X86FastISel.cpp +++ b/lib/Target/X86/X86FastISel.cpp @@ -585,10 +585,6 @@ X86FastISel::TargetSelectInstruction(Instruction *I) { unsigned X86FastISel::TargetMaterializeConstant(Constant *C, MachineConstantPool* MCP) { - unsigned CPLoad = getRegForValue(C); - if (CPLoad != 0) - return CPLoad; - // Can't handle PIC-mode yet. if (TM.getRelocationModel() == Reloc::PIC_) return 0; @@ -662,10 +658,17 @@ unsigned X86FastISel::TargetMaterializeConstant(Constant *C, return 0; } + // MachineConstantPool wants an explicit alignment. + unsigned Align = + TM.getTargetData()->getPreferredTypeAlignmentShift(C->getType()); + if (Align == 0) { + // Alignment of vector types. FIXME! + Align = TM.getTargetData()->getABITypeSize(C->getType()); + Align = Log2_64(Align); + } - unsigned MCPOffset = MCP->getConstantPoolIndex(C, 0); + unsigned MCPOffset = MCP->getConstantPoolIndex(C, Align); addConstantPoolReference(BuildMI(MBB, TII.get(Opc), ResultReg), MCPOffset); - UpdateValueMap(C, ResultReg); return ResultReg; } diff --git a/lib/Target/X86/X86InstrBuilder.h b/lib/Target/X86/X86InstrBuilder.h index d4e10bbb50e..b5924cb7611 100644 --- a/lib/Target/X86/X86InstrBuilder.h +++ b/lib/Target/X86/X86InstrBuilder.h @@ -119,9 +119,7 @@ addFrameReference(const MachineInstrBuilder &MIB, int FI, int Offset = 0) { /// offset to be added as well. /// inline const MachineInstrBuilder & -addConstantPoolReference(const MachineInstrBuilder &MIB, unsigned CPI, - int Offset = 0) { - assert(Offset == 0 && "Non-zero offsets not supported!"); +addConstantPoolReference(const MachineInstrBuilder &MIB, unsigned CPI) { return MIB.addReg(0).addImm(1).addReg(0).addConstantPoolIndex(CPI); }