mirror of
https://github.com/c64scene-ar/llvm-6502.git
synced 2024-08-17 05:29:24 +00:00
Fix addRegisterDead and addRegisterKilled to be more thorough
when searching for redundant subregister dead/kill bits. Previously it was common to see instructions marked like this: "RET %EAX<imp-use,kill>, %AX<imp-use,kill>" With this change, addRegisterKilled continues scanning after finding the %EAX operand, so it proceeds to discover the redundant %AX kill and eliminates it, producing this: "RET %EAX<imp-use,kill>" This currently has no effect on the generated code. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@55698 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
parent
d0ac373660
commit
3f62940561
@ -800,6 +800,7 @@ bool MachineInstr::addRegisterKilled(unsigned IncomingReg,
|
||||
bool AddIfNotFound) {
|
||||
bool isPhysReg = TargetRegisterInfo::isPhysicalRegister(IncomingReg);
|
||||
bool hasAliases = isPhysReg && RegInfo->getAliasSet(IncomingReg);
|
||||
bool Found = false;
|
||||
SmallVector<unsigned,4> DeadOps;
|
||||
for (unsigned i = 0, e = getNumOperands(); i != e; ++i) {
|
||||
MachineOperand &MO = getOperand(i);
|
||||
@ -810,10 +811,14 @@ bool MachineInstr::addRegisterKilled(unsigned IncomingReg,
|
||||
continue;
|
||||
|
||||
if (Reg == IncomingReg) {
|
||||
MO.setIsKill();
|
||||
if (!Found) {
|
||||
if (MO.isKill())
|
||||
// The register is already marked kill.
|
||||
return true;
|
||||
MO.setIsKill();
|
||||
Found = true;
|
||||
}
|
||||
if (hasAliases && MO.isKill() &&
|
||||
} else if (hasAliases && MO.isKill() &&
|
||||
TargetRegisterInfo::isPhysicalRegister(Reg)) {
|
||||
// A super-register kill already exists.
|
||||
if (RegInfo->isSuperRegister(IncomingReg, Reg))
|
||||
@ -835,14 +840,14 @@ bool MachineInstr::addRegisterKilled(unsigned IncomingReg,
|
||||
|
||||
// If not found, this means an alias of one of the operands is killed. Add a
|
||||
// new implicit operand if required.
|
||||
if (AddIfNotFound) {
|
||||
if (!Found && AddIfNotFound) {
|
||||
addOperand(MachineOperand::CreateReg(IncomingReg,
|
||||
false /*IsDef*/,
|
||||
true /*IsImp*/,
|
||||
true /*IsKill*/));
|
||||
return true;
|
||||
}
|
||||
return false;
|
||||
return Found;
|
||||
}
|
||||
|
||||
bool MachineInstr::addRegisterDead(unsigned IncomingReg,
|
||||
@ -850,17 +855,25 @@ bool MachineInstr::addRegisterDead(unsigned IncomingReg,
|
||||
bool AddIfNotFound) {
|
||||
bool isPhysReg = TargetRegisterInfo::isPhysicalRegister(IncomingReg);
|
||||
bool hasAliases = isPhysReg && RegInfo->getAliasSet(IncomingReg);
|
||||
bool Found = false;
|
||||
SmallVector<unsigned,4> DeadOps;
|
||||
for (unsigned i = 0, e = getNumOperands(); i != e; ++i) {
|
||||
MachineOperand &MO = getOperand(i);
|
||||
if (!MO.isRegister() || !MO.isDef())
|
||||
continue;
|
||||
unsigned Reg = MO.getReg();
|
||||
if (!Reg)
|
||||
continue;
|
||||
|
||||
if (Reg == IncomingReg) {
|
||||
MO.setIsDead();
|
||||
if (!Found) {
|
||||
if (MO.isDead())
|
||||
// The register is already marked dead.
|
||||
return true;
|
||||
MO.setIsDead();
|
||||
Found = true;
|
||||
}
|
||||
if (hasAliases && MO.isDead() &&
|
||||
} else if (hasAliases && MO.isDead() &&
|
||||
TargetRegisterInfo::isPhysicalRegister(Reg)) {
|
||||
// There exists a super-register that's marked dead.
|
||||
if (RegInfo->isSuperRegister(IncomingReg, Reg))
|
||||
@ -882,13 +895,15 @@ bool MachineInstr::addRegisterDead(unsigned IncomingReg,
|
||||
DeadOps.pop_back();
|
||||
}
|
||||
|
||||
// If not found, this means an alias of one of the operand is dead. Add a
|
||||
// new implicit operand.
|
||||
if (AddIfNotFound) {
|
||||
addOperand(MachineOperand::CreateReg(IncomingReg, true/*IsDef*/,
|
||||
true/*IsImp*/,false/*IsKill*/,
|
||||
true/*IsDead*/));
|
||||
// If not found, this means an alias of one of the operands is dead. Add a
|
||||
// new implicit operand if required.
|
||||
if (!Found && AddIfNotFound) {
|
||||
addOperand(MachineOperand::CreateReg(IncomingReg,
|
||||
true /*IsDef*/,
|
||||
true /*IsImp*/,
|
||||
false /*IsKill*/,
|
||||
true /*IsDead*/));
|
||||
return true;
|
||||
}
|
||||
return false;
|
||||
return Found;
|
||||
}
|
||||
|
Loading…
Reference in New Issue
Block a user