6502/llvm-6502
1
0
Fork 0
mirror of https://github.com/c64scene-ar/llvm-6502.git synced 2025-08-07 12:28:24 +00:00
Code Issues Projects Releases Wiki Activity

Refactor: Simplify boolean expressions in x86 target

Browse Source 
Simplify boolean expressions with `true` and `false` with `clang-tidy`

Patch by Richard Thomson.

Differential Revision: http://reviews.llvm.org/D8519

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@233002 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
David Blaikie
2015-03-23 19:42:36 +00:00
parent 1bfcd1f675
commit 3fb6269121
3 changed files with 5 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
lib/Target/X86/Disassembler/X86DisassemblerDecoder.cpp
View File

@@ -310,11 +310,8 @@ static bool isPrefixAtLocation(struct InternalInstruction* insn,
uint8_t prefix, uint8_t prefix,
uint64_t location) uint64_t location)
{ {
if (insn->prefixPresent[prefix] == 1 && return insn->prefixPresent[prefix] == 1 &&
insn->prefixLocations[prefix] == location) insn->prefixLocations[prefix] == location;
return true;
else
return false;
} }
/* /*

2
lib/Target/X86/MCTargetDesc/X86ELFRelocationInfo.cpp
View File

@@ -36,7 +36,7 @@ public:
MCSymbol *Sym = Ctx.GetOrCreateSymbol(SymName); MCSymbol *Sym = Ctx.GetOrCreateSymbol(SymName);
// FIXME: check that the value is actually the same. // FIXME: check that the value is actually the same.
if (Sym->isVariable() == false) if (!Sym->isVariable())
Sym->setVariableValue(MCConstantExpr::Create(SymAddr, Ctx)); Sym->setVariableValue(MCConstantExpr::Create(SymAddr, Ctx));
const MCExpr *Expr = nullptr; const MCExpr *Expr = nullptr;

4
lib/Target/X86/MCTargetDesc/X86MachORelocationInfo.cpp
View File

@@ -38,7 +38,7 @@ public:
MCSymbol *Sym = Ctx.GetOrCreateSymbol(SymName); MCSymbol *Sym = Ctx.GetOrCreateSymbol(SymName);
// FIXME: check that the value is actually the same. // FIXME: check that the value is actually the same.
if (Sym->isVariable() == false) if (!Sym->isVariable())
Sym->setVariableValue(MCConstantExpr::Create(SymAddr, Ctx)); Sym->setVariableValue(MCConstantExpr::Create(SymAddr, Ctx));
const MCExpr *Expr = nullptr; const MCExpr *Expr = nullptr;
@@ -93,7 +93,7 @@ public:
RSymI->getName(RSymName); RSymI->getName(RSymName);
MCSymbol *RSym = Ctx.GetOrCreateSymbol(RSymName); MCSymbol *RSym = Ctx.GetOrCreateSymbol(RSymName);
if (RSym->isVariable() == false) if (!RSym->isVariable())
RSym->setVariableValue(MCConstantExpr::Create(RSymAddr, Ctx)); RSym->setVariableValue(MCConstantExpr::Create(RSymAddr, Ctx));
const MCExpr *RHS = MCSymbolRefExpr::Create(RSym, Ctx); const MCExpr *RHS = MCSymbolRefExpr::Create(RSym, Ctx);